Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [PATCH] use ORTE_PROC_IS_APP
From: Ralph Castain (rhc_at_[hidden])
Date: 2014-01-23 11:17:24


Sure - no issues with me

On Jan 23, 2014, at 7:10 AM, Adrian Reber <adrian_at_[hidden]> wrote:

> Selecting SNAPC requires the information if it is an app or not:
>
> int orte_snapc_base_select(bool seed, bool app);
>
> The following patch uses the correct define. Can I commit it like this:
>
> t a/orte/mca/ess/base/ess_base_std_app.c b/orte/mca/ess/base/ess_base_std_app.c
> index dbbb2f4..f3a38f0 100644
> --- a/orte/mca/ess/base/ess_base_std_app.c
> +++ b/orte/mca/ess/base/ess_base_std_app.c
> @@ -252,7 +252,7 @@ int orte_ess_base_app_setup(bool db_restrict_local)
> error = "orte_sstore_base_open";
> goto error;
> }
> - if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, !ORTE_PROC_IS_DAEMON))) {
> + if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, ORTE_PROC_IS_APP))) {
> ORTE_ERROR_LOG(ret);
> error = "orte_snapc_base_select";
> goto error;
> diff --git a/orte/mca/ess/base/ess_base_std_tool.c b/orte/mca/ess/base/ess_base_std_tool.c
> index 98c1685..7fcf83d 100644
> --- a/orte/mca/ess/base/ess_base_std_tool.c
> +++ b/orte/mca/ess/base/ess_base_std_tool.c
> @@ -189,7 +189,7 @@ int orte_ess_base_tool_setup(void)
> error = "orte_snapc_base_open";
> goto error;
> }
> - if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, !ORTE_PROC_IS_DAEMON))) {
> + if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, ORTE_PROC_IS_APP))) {
> ORTE_ERROR_LOG(ret);
> error = "orte_snapc_base_select";
> goto error;
> diff --git a/orte/mca/ess/hnp/ess_hnp_module.c b/orte/mca/ess/hnp/ess_hnp_module.c
> index a6f1777..ea444c4 100644
> --- a/orte/mca/ess/hnp/ess_hnp_module.c
> +++ b/orte/mca/ess/hnp/ess_hnp_module.c
> @@ -678,7 +678,7 @@ static int rte_init(void)
> error = "orte_sstore_base_open";
> goto error;
> }
> - if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, !ORTE_PROC_IS_DAEMON))) {
> + if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, ORTE_PROC_IS_APP))) {
> ORTE_ERROR_LOG(ret);
> error = "orte_snapc_base_select";
> goto error;
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel