Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |  

This web mail archive is frozen.

This page is part of a frozen web archive of this mailing list.

You can still navigate around this archive, but know that no new mails have been added to it since July of 2016.

Click here to be taken to the new web archives of this list; it includes all the mails that are in this frozen archive plus all new mails that have been sent to the list since it was migrated to the new archives.

Subject: [OMPI devel] trunk: typo in error message
From: Paul Hargrove (phhargrove_at_[hidden])
Date: 2014-01-23 02:33:25


As originally noted in Dec 2011 (
http://www.open-mpi.org/community/lists/devel/2011/12/10169.php) there is a
1-character typo in generate-asm.pl:

$ cat -n generate-asm.pl | head -20
     1 #!/usr/bin/perl -w
     2
     3
     4 my $asmarch = shift;
     5 my $asmformat = shift;
     6 my $basedir = shift;
     7 my $output = shift;
     8
     9 if ( ! $asmarch) {
    10 print "usage: generate-asm.pl [ASMARCH] [ASMFORMAT] [BASEDIR]
[OUTPUT NAME]\n";
    11 exit(1);
    12 }
    13
    14 open(INPUT, "$basedir/$asmarch.asm") ||
    15 die "Could not open $basedir/$asmarch.asm: $!\n";
    16 open(OUTPUT, ">$output") || die "Could not open $output: $1\n";
    17
    18 $CONFIG = "default";
    19 $TEXT = "";
    20 $GLOBAL = "";

The "$1" on line 16 should actually be "$!".
The perl variable "$1" is the result of a prior pattern match, of which
there ARE NONE.
The perl variable "$!", however, is the equivalent of "strerror(errno)" in
C.

This typo is still present in today's trunk.
It is, of course, entirely harmless.

-Paul

-- 
Paul H. Hargrove                          PHHargrove_at_[hidden]
Future Technologies Group
Computer and Data Sciences Department     Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory     Fax: +1-510-486-6900