Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [Patch] For Fortran, support GCC/gfortran 4.9's TYPE(*) with NO_ARG_CHECK
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2014-01-07 22:43:03


Many thanks for the reminder; this had totally slipped off my radar. :-(

Oy, yes, I added this in my bitbucket forever ago and forgot to bring it to the trunk! :-(

It looks like that bitbucket is in bad shape -- I just svn up'ed it, and it no longer compiles. I suspect some conflicts crept in unnoticed over time.

But I'll take your patch, definitely. I'll put it on the SVN trunk and schedule it for OMPI 1.7.5 (it's too late for 1.7.4).

Thank you!

On Jan 7, 2014, at 4:18 PM, Tobias Burnus <burnus_at_[hidden]> wrote:

> Hello,
>
> I'd like to see the following patch to be included in Open MPI, which enabled interface checking also with GCC's gfortran.
>
> While TYPE(*), DIMENSION(*) is already tested for, it cannot be used for scalars (and "TYPE(*)" cannot be used with arrays). [Those were added in GCC 4.8, which diagnoses the rank mismatch. Fortran 2015 (?) will add support for both scalars and dimensions.]
>
> In GCC 4.9, gfortran joins other compilers by supporting a directive which disables the argument check (type, kind, rank checking: TKR): NO_ARG_CHECK.
>
> The attached patch does so. The original version has been added 8 months ago to https://bitbucket.org/jsquyres/mpi3-fortran/commits/243ffae9f63ffc8fcdfdc604796ef290963ea1c4 - but as it hasn't been merged to the Open MPI, I submit it with this email (rediffed with some additional cases).
>
> I'd be delighted if the patch could be applied to the trunk - and possibly even be backported to 1.7. (I think it also applies to 1.6 but I haven't checked.)
>
> Tobias
> <gcc-no-arg-check.diff>_______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/