Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r29917 - trunk/ompi/mca/rte/orte
From: Ralph Castain (rhc_at_[hidden])
Date: 2013-12-15 12:18:13


This actually creates a bit of a problem. The reason we did this was because the OMPI-layer "show-help" calls want to report the hostname of the proc. Since we don't retrieve that info by default, the show-help calls all fail due to a NULL pointer.

Nathan tried wrapping all the show-help calls with a modex-fetch of hostname, but that isn't a good solution as the fetch might fail depending on the problem we are trying to report.

We also noted that the modex recv's current implemented all fetched the complete RTE-level info whenever any info was requested for that proc. So the fetch of the hostname was a very low cost operation.

So we decided to always ensure we load the hostname info if it hasn't already been done, thus keeping the show-help operations functional.

Make sense? Or do you have an alternative method?
Ralph

On Dec 15, 2013, at 8:54 AM, svn-commit-mailer_at_[hidden] wrote:

> Author: bosilca (George Bosilca)
> Date: 2013-12-15 11:54:01 EST (Sun, 15 Dec 2013)
> New Revision: 29917
> URL: https://svn.open-mpi.org/trac/ompi/changeset/29917
>
> Log:
> Don't be greedy, just do what we asked for.
>
> Text files modified:
> trunk/ompi/mca/rte/orte/rte_orte_module.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> Modified: trunk/ompi/mca/rte/orte/rte_orte_module.c
> ==============================================================================
> --- trunk/ompi/mca/rte/orte/rte_orte_module.c Sun Dec 15 11:49:27 2013 (r29916)
> +++ trunk/ompi/mca/rte/orte/rte_orte_module.c 2013-12-15 11:54:01 EST (Sun, 15 Dec 2013) (r29917)
> @@ -153,11 +153,6 @@
> if (OPAL_SUCCESS != (rc = opal_db.fetch((opal_identifier_t*)nm, key, data, type))) {
> return rc;
> }
> - /* update the hostname */
> - proct = ompi_proc_find(nm);
> - if (NULL == proct->proc_hostname) {
> - opal_db.fetch_pointer((opal_identifier_t*)nm, ORTE_DB_HOSTNAME, (void**)&proct->proc_hostname, OPAL_STRING);
> - }
> return OMPI_SUCCESS;
> }
>
> @@ -171,11 +166,6 @@
> if (OPAL_SUCCESS != (rc = opal_db.fetch_pointer((opal_identifier_t*)nm, key, data, type))) {
> return rc;
> }
> - /* update the hostname */
> - proct = ompi_proc_find(nm);
> - if (NULL == proct->proc_hostname) {
> - opal_db.fetch_pointer((opal_identifier_t*)nm, ORTE_DB_HOSTNAME, (void**)&proct->proc_hostname, OPAL_STRING);
> - }
> return OMPI_SUCCESS;
> }
>
> @@ -191,11 +181,6 @@
> OPAL_SCOPE_GLOBAL, key, kvs))) {
> return rc;
> }
> - /* update the hostname */
> - proct = ompi_proc_find(nm);
> - if (NULL == proct->proc_hostname) {
> - opal_db.fetch_pointer((opal_identifier_t*)nm, ORTE_DB_HOSTNAME, (void**)&proct->proc_hostname, OPAL_STRING);
> - }
> return OMPI_SUCCESS;
> }
>
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn