Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)
From: Adrian Reber (adrian_at_[hidden])
Date: 2013-12-09 05:11:35


On Fri, Dec 06, 2013 at 08:43:39AM -0600, Josh Hursey wrote:
> Did the mca_base_component_distill_checkpoint_ready paramter go away? Its
> intention was to allow a user to have a build with C/R compiled in and then
> choose at runtime if they want to restrict their component section to just
> C/R enabled components or not. I have reservations about that part of the
> patch.

It really is gone (as far as I understand it). The only occurrence is in
a parameter file, but it is not available as a C variable:

$ git grep mca_base_component_distill_checkpoint_ready
contrib/amca-param-sets/ft-enable-cr:mca_base_component_distill_checkpoint_ready=1
contrib/amca-param-sets/ft-enable-cr-recovery:mca_base_component_distill_checkpoint_ready=1

> If it is a compilation issue and that MCA parameter was lost, then I would
> leave the code in an #ifdef so we come back and make sure that
> functionality is preserved in the final version.
>
> I think if you fix the distill_checkpoint issue, then this patch is ok with
> me.

I will resubmit this patch with the proposed fixes.

                Adrian