Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)
From: Adrian Reber (adrian_at_[hidden])
Date: 2013-12-05 04:55:59


On Wed, Dec 04, 2013 at 08:07:39PM +0000, Jeff Squyres (jsquyres) wrote:
> On Dec 4, 2013, at 11:29 AM, Ralph Castain <rhc.openmpi_at_[hidden]> wrote:
>
> > Jeff - you are jumping way ahead. I already said this needs further work to resolve blocking. These patches (per Adrian's email) just makes things compile
>
> Fair enough.
>
> But in some ways, having uncompilable code is a *good* thing, because it tells you exactly where you need to work on the architecture. Just updating it to *compile* removes that safeguard -- will you remember/re-find all those places where it *used* to block and convert the architecture to workaround the blocking?
>
> I guess I'm saying: what exactly does updating it to compile get for us, if we know the code still won't work? It seems like all we'll be doing is removing the grep-able places where we *know* we'll have to do work in the future.

My goal was to let people see what I am doing and especially to decrease
the number of patches I have to carry locally. I am not familiar enough with
the Open MPI code (yet) to fix it correctly in the first try. Without
having a code which compiles I personally cannot continue fixing the
functionality. These patches are the first step which I wanted to make
public. I can update the patches to include 'FIXME' in all the place if
required.

                Adrian