Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)
From: Paul Hargrove (phhargrove_at_[hidden])
Date: 2013-12-04 15:51:56


On Dec 4, 2013 12:07 PM, "Jeff Squyres (jsquyres)" <jsquyres_at_[hidden]>
wrote:
[...]
> But in some ways, having uncompilable code is a *good* thing, because it
tells you exactly where you need to work on the architecture. Just
updating it to *compile* removes that safeguard -- will you
remember/re-find all those places where it *used* to block and convert the
architecture to workaround the blocking?

+1

IMHO code that doesn't compile is much better than code that compiles but
is known to be broken.

Adding a grepable "FIXME" sort of comment to each of these known broken
code blocks would seem to be a decent compromise.

-Paul [Sent from my phone]