Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [EXTERNAL] Re: oshmem and CFLAGS removal
From: Barrett, Brian W (bwbarre_at_[hidden])
Date: 2013-10-31 16:44:50

On 10/31/13 2:42 PM, "Rolf vandeVaart" <rvandevaart_at_[hidden]> wrote:

>>-----Original Message-----
>>From: devel [mailto:devel-bounces_at_[hidden]] On Behalf Of Jeff Squyres
>>Sent: Thursday, October 31, 2013 4:12 PM
>>To: Open MPI Developers
>>Subject: Re: [OMPI devel] oshmem and CFLAGS removal
>>On Oct 31, 2013, at 3:46 PM, Rolf vandeVaart <rvandevaart_at_[hidden]>
>>> # Strip off problematic arguments
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-pedantic//g'`"
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wundef//g'`"
>>> oshmem_CFLAGS="`echo $oshmem_CFLAGS | sed 's/-Wno-long-
>>I think the solution is simple -- delete this line:
>>> CFLAGS="$oshmem_CFLAGS"
>Nope, it was not that simple. With that change, the -pedantic and
>-Wundef end up in the CFLAGS for oshmem and I see all the warnings.
>I will submit a ticket and give it to Joshua Ladd.

Yeah, that's not going to work. But a bigger question: why aren't
-pedantic and -Wundef set for SHMEM? If it's an OMPI project, it has to
follow all the rules the other OMPI projects follow.


  Brian W. Barrett
  Scalable System Software Group
  Sandia National Laboratories