Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r29475 - trunk/ompi/proc
From: Ralph Castain (rhc_at_[hidden])
Date: 2013-10-22 17:48:06


I don't have an issue with this change, but I confess I'm struggling to
understand what it did. Can you please explain how this change actually
changed something?

Thanks
Ralph

On Tue, Oct 22, 2013 at 12:07 PM, <svn-commit-mailer_at_[hidden]> wrote:

> Author: hjelmn (Nathan Hjelm)
> Date: 2013-10-22 15:07:03 EDT (Tue, 22 Oct 2013)
> New Revision: 29475
> URL: https://svn.open-mpi.org/trac/ompi/changeset/29475
>
> Log:
> Fix locality when in the case where the OMPI_RTE_HOST_ID is not found.
>
> cmr=v1.7.4:ticket=3847
>
> Text files modified:
> trunk/ompi/proc/proc.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> Modified: trunk/ompi/proc/proc.c
>
> ==============================================================================
> --- trunk/ompi/proc/proc.c Tue Oct 22 14:48:07 2013 (r29474)
> +++ trunk/ompi/proc/proc.c 2013-10-22 15:07:03 EDT (Tue, 22 Oct 2013)
> (r29475)
> @@ -150,6 +150,7 @@
> }
> /* if we are on different nodes, then we are probably non-local */
> if (vpid != OMPI_RTE_MY_NODEID) {
> + locality = OPAL_PROC_NON_LOCAL;
> #ifdef OMPI_RTE_HOST_ID
> /* see if coprocessors were detected - if the hostid isn't
> * present, then no coprocessors were detected and we can
> @@ -167,8 +168,6 @@
> locality = OPAL_PROC_NON_LOCAL;
> }
> }
> -#else
> - locality = OPAL_PROC_NON_LOCAL;
> #endif
> } else {
> #if OPAL_HAVE_HWLOC
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>