Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] RFC: Neighborhood collective support
From: David Goodell (dgoodell) (dgoodell_at_[hidden])
Date: 2013-09-20 12:40:05


On Sep 19, 2013, at 3:07 PM, "Hjelm, Nathan T" <hjelmn_at_[hidden]> wrote:

> I have implemented simple tests for cartesian, graph, and dist graph topologies for the Open MPI/IBM test suite and all tests pass. I will push those tests to MTT tomorrow.

Consider also grabbing the dist graph and neighborhood collective tests from MPICH and running them against your proposed patch. I recall catching a lot of subtle cases with these tests when I implemented this functionality in MPICH. Specifically, I'm thinking of these tests:

http://git.mpich.org/mpich.git/blob/HEAD:/test/mpi/topo/dgraph_unwgt.c
http://git.mpich.org/mpich.git/blob/HEAD:/test/mpi/topo/neighb_coll.c
http://git.mpich.org/mpich.git/blob/HEAD:/test/mpi/topo/distgraph1.c
http://git.mpich.org/mpich.git/blob/HEAD:/test/mpi/f77/topo/dgraph_unwgtf.f
http://git.mpich.org/mpich.git/blob/HEAD:/test/mpi/f77/topo/dgraph_wgtf.f

Some of them might be annoying to run, since they depend on the "MTest" utility code. But they wouldn't be too hard to tweak to use plain MPI instead. Let me know if you run into trouble, I'm happy to point you in the right direction.

-Dave