Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] RFC: add support for large counts using derived datatypes
From: Nathan Hjelm (hjelmn_at_[hidden])
Date: 2013-07-16 16:56:03


I think you meant signed. It is signed in both configure.ac and ompi_datatype_module.c.

-Nathan

On Tue, Jul 16, 2013 at 10:48:12PM +0200, George Bosilca wrote:
> It's a typo, MPI_Aint is of course unsigned.
>
> George.
>
> On Jul 16, 2013, at 22:37 , David Goodell (dgoodell) <dgoodell_at_[hidden]> wrote:
>
> > On Jul 16, 2013, at 3:22 PM, George Bosilca <bosilca_at_[hidden]> wrote:
> >
> >> I read your code and it's definitively looking good. I have however few minor issues with your patch.
> >>
> >> 1. MPI_Aint is unsigned as it must represent the difference between two memory arbitrary locations. In your MPI_Type_get_[true_]extent_x you go through size_t possibly reducing it's extent. I would suggest you used ssize_t instead.
> >
> > MPI_Aint must be signed for Fortran compatibility (among other reasons). If OMPI's MPI_Aint is unsigned then that's a bug in OMPI.
> >
> > -Dave
> >
> >
> > _______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel