Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] RFC: add support for large counts using derived datatypes
From: David Goodell (dgoodell) (dgoodell_at_[hidden])
Date: 2013-07-16 16:37:18


On Jul 16, 2013, at 3:22 PM, George Bosilca <bosilca_at_[hidden]> wrote:

> I read your code and it's definitively looking good. I have however few minor issues with your patch.
>
> 1. MPI_Aint is unsigned as it must represent the difference between two memory arbitrary locations. In your MPI_Type_get_[true_]extent_x you go through size_t possibly reducing it's extent. I would suggest you used ssize_t instead.

MPI_Aint must be signed for Fortran compatibility (among other reasons). If OMPI's MPI_Aint is unsigned then that's a bug in OMPI.

-Dave