Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [bug] One-sided communication with a duplicated datatype
From: George Bosilca (bosilca_at_[hidden])
Date: 2013-07-15 06:54:49


Thanks for testing it. It is now in trunk r28790.

  George.

On Jul 15, 2013, at 12:29 , KAWASHIMA Takahiro <rivis.kawashima_at_[hidden]> wrote:

> George,
>
> Thanks. I've confirmed your patch.
> I wrote a simple program to test your patch and no problems are found.
> The test program is attached to this mail.
>
> Regards,
> KAWASHIMA Takahiro
>
>> Takahiro,
>>
>> Please find below another patch, this time hopefully fixing all issues. The problem with my original patch and with yours was that they try to address the packing of the data representation without fixing the computation of the required length. As a result the length on the packer and unpacker differs and the unpacking of the subsequent data is done from a wrong location.
>>
>> I changed the code to force the preparation of the packed data representation before returning the length the first time. This way we can compute exactly how many bytes we need, including the potential alignment requirements. As a result the amount on both sides (the packer and the unpacker) are now identical, and the entire process works flawlessly (or so I hope).
>>
>> Let me know if you still notice issues with this patch. I'll push the tomorrow in the trunk, so it can soak for a few days before propagation to the branches.
> <put_dup_type_4.c>_______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel