Thanks for the patch and for the tests. All these changes/cleanups are correct, I have incorporate them all in the patch. Please find below the new patch.
As the deadline for the RFC is today, I'll move forward and push the changes into the trunk, and if there are still issues we can work them out directly in the trunk.
PS: I will push your tests in our tests base as well.
On Jul 1, 2013, at 06:39 , "Kawashima, Takahiro" <t-kawashima_at_[hidden]> wrote:
> My colleague was working on your ompi-topo bitbucket repository
> but it was not completed. But he found bugs in your patch attached
> in your previous mail and created the fixing patch. See the attached
> patch, which is a patch against Open MPI trunk + your patch.
> His test programs are also attached. test_1 and test_2 can run
> with nprocs=5, and test_3 and test_4 can run with nprocs>=3.
> Though I'm not sure about the contents of the patch and the test
> programs, I can ask him if you have any questions.
> Takahiro Kawashima,
> MPI development team,
>> WHAT: Support for MPI 2.2 dist_graph
>> WHY: To become [almost entierly] MPI 2.2 compliant
>> WHEN: Monday July 1st
>> As discussed during the last phone call, a missing functionality of the MPI 2.2 standard (the distributed graph topology) is ready for prime-time. The attached patch provide a minimal version (no components supporting reordering), that will complete the topology support in Open MPI.
>> It is somehow a major change compared with what we had before and it reshape the way we deal with topologies completely. Where our topologies were mainly storage components (they were not capable of creating the new communicator as an example), the new version is built around a [possibly] common representation (in mca/topo/topo.h), but the functions to attach and retrieve the topological information are specific to each component. As a result the ompi_create_cart and ompi_create_graph functions become useless and have been removed.
>> In addition to adding the internal infrastructure to manage the topology information, it updates the MPI interface, and the debuggers support and provides all Fortran interfaces. From a correctness point of view it passes all the tests we have in ompi-tests for the cart and graph topology, and some tests/applications for the dist_graph interface.
>> I don't think there is a need for a long wait on this one so I would like to propose a short deadline, a week from now on Monday July 1st. A patch based on Open MPI trunk r28670 is attached below.
> devel mailing list