Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [bug/fix] correction of a small bug in conf file parsing
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2013-06-21 09:03:57


On Jun 21, 2013, at 7:40 AM, Piotr Lesnicki <piotr.lesnicki_at_[hidden]> wrote:

> 1) you are right, an eof in the middle of a <comment> section must be
> handled explicitly, otherwise it ends by an unrelated error later,
> just as it currently does. By the way, here it ends with
> [no-options-error] which has no corresponding message in
> 'help-opal-wrapper.txt'.
>
> I joined the patch to correct this <comment> problem.

Sweet. Sounds like this was a long-standing problem.

> 2) indeed, other lex files have similar patterns to 'keyval_lex.l', so
> we should correct them also. I will take a look at them.

Thanks!

Can you submit a combined patch when ready?

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/