Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r28016 - trunk/ompi/mca/btl/tcp
From: George Bosilca (bosilca_at_[hidden])
Date: 2013-02-01 18:28:04


Jeff,

So far, all interfaces specified via MCA parameters for the BTL TCP
are required to exist. Otherwise an error message is printed and an
error returned to the upper level, with the intent that no BTLs of
this type will be enabled (as an example btl_tcp_component.c:682).

If I correctly understand your commit, it change this [so far
consistent] behavior for a single of our TCP MCA parameter (if_seq)
to: print an error message and then continue. As you set
themca_btl_tcp_component.tcp_if_seq to NULL this is as if this
argument was never provided.

I prefer the old behavior for its corrective meaning (you fix it and
then it works), as well as for its consistency with the other BTL TCP
parameters.

  George.

On Fri, Feb 1, 2013 at 3:17 PM, <svn-commit-mailer_at_[hidden]> wrote:
> Author: jsquyres (Jeff Squyres)
> Date: 2013-02-01 15:17:43 EST (Fri, 01 Feb 2013)
> New Revision: 28016
> URL: https://svn.open-mpi.org/trac/ompi/changeset/28016
>
> Log:
> As the help message states, it's not an ''error'' if the specified
> interface is not found. It should just be skipped.
>
> Text files modified:
> trunk/ompi/mca/btl/tcp/btl_tcp_component.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> Modified: trunk/ompi/mca/btl/tcp/btl_tcp_component.c
> ==============================================================================
> --- trunk/ompi/mca/btl/tcp/btl_tcp_component.c Fri Feb 1 09:27:37 2013 (r28015)
> +++ trunk/ompi/mca/btl/tcp/btl_tcp_component.c 2013-02-01 15:17:43 EST (Fri, 01 Feb 2013) (r28016)
> @@ -314,10 +314,12 @@
> ompi_process_info.nodename,
> mca_btl_tcp_component.tcp_if_seq,
> "Interface does not exist");
> - return OMPI_ERR_BAD_PARAM;
> + free(mca_btl_tcp_component.tcp_if_seq);
> + mca_btl_tcp_component.tcp_if_seq = NULL;
> + } else {
> + BTL_VERBOSE(("Node rank %d using TCP interface %s",
> + node_rank, mca_btl_tcp_component.tcp_if_seq));
> }
> - BTL_VERBOSE(("Node rank %d using TCP interface %s",
> - node_rank, mca_btl_tcp_component.tcp_if_seq));
> }
> }
>
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn