Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: [OMPI devel] New warning in btl_openib_endpoint.h
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2013-01-11 10:01:20


It looks like a recent change to btl_openib_endpoint.h is resulting in warnings -- the code is a bit ambiguous:

-----
    if (ep->qps[qp].qp->sd_wqe <= 0 ||
            size + sizeof(mca_btl_openib_header_t) + (rdma ? sizeof(mca_btl_openib_footer_t) : 0) > ep->qps[qp].ib_inline_max ||
             !BTL_OPENIB_QP_TYPE_PP(qp) && ep->endpoint_btl->qps[qp].u.srq_qp.sd_credits <= 0) {
-----

Results in the following warning:

./btl_openib_endpoint.h:307: warning: suggest parentheses around '&&' within '||'

*** Mellanox: did you mean to put parentheses around the || or the && ?

I think the fix for this will need to go to v1.6 and v1.7, because this new code has already been pushed to those branches (bad reviewing! :-( :-( :-( ).

(this code is already in v1.7; there's a CMR waiting for the gk to apply it to v1.6)

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/