Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27744 - trunk/ompi/runtime
From: Ralph Castain (rhc_at_[hidden])
Date: 2013-01-04 16:08:25


I guess it's actually the "recv_string_pointer" function that is used for this purpose, but I'd rather not just willy-nilly prune functions out of the code base because they aren't currently used. If we apply that criteria, a lot of functions that are there for future and/or historical reasons would be eliminated - and eventually likely restored.

I don't see how this function hurt anyone - other than esthetics, is there a reason why this particular function must be removed?

On Jan 4, 2013, at 1:01 PM, Ralph Castain <rhc_at_[hidden]> wrote:

> Whoa - that function is used, I believe, to retrieve the pointer to the hostname info in the ompi_proc_t
>
>
> On Jan 4, 2013, at 12:50 PM, svn-commit-mailer_at_[hidden] wrote:
>
>> Author: bosilca (George Bosilca)
>> Date: 2013-01-04 15:50:25 EST (Fri, 04 Jan 2013)
>> New Revision: 27744
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27744
>>
>> Log:
>> Remove the unnecessary ompi_modex_recv_pointer function.
>>
>> Text files modified:
>> trunk/ompi/runtime/ompi_module_exchange.c | 22 ----------------------
>> trunk/ompi/runtime/ompi_module_exchange.h | 5 -----
>> 2 files changed, 0 insertions(+), 27 deletions(-)
>>
>> Modified: trunk/ompi/runtime/ompi_module_exchange.c
>> ==============================================================================
>> --- trunk/ompi/runtime/ompi_module_exchange.c Fri Jan 4 15:47:25 2013 (r27743)
>> +++ trunk/ompi/runtime/ompi_module_exchange.c 2013-01-04 15:50:25 EST (Fri, 04 Jan 2013) (r27744)
>> @@ -90,28 +90,6 @@
>> return rc;
>> }
>>
>> -/* return a pointer to the data, but don't create a new copy of it */
>> -int ompi_modex_recv_pointer(const mca_base_component_t *component,
>> - const ompi_proc_t *proc,
>> - void **buffer, opal_data_type_t type)
>> -{
>> - int rc;
>> - char *name = mca_base_component_to_string(component);
>> -
>> - /* set defaults */
>> - *buffer = NULL;
>> -
>> - if (NULL == name) {
>> - return OMPI_ERR_OUT_OF_RESOURCE;
>> - }
>> -
>> - /* the fetch_poointer API returns a pointer to the data */
>> - rc = orte_db.fetch_pointer(&proc->proc_name, name, buffer, type);
>> - free(name);
>> -
>> - return rc;
>> -}
>> -
>> int
>> ompi_modex_send_string(const char* key,
>> const void *buffer, size_t size)
>>
>> Modified: trunk/ompi/runtime/ompi_module_exchange.h
>> ==============================================================================
>> --- trunk/ompi/runtime/ompi_module_exchange.h Fri Jan 4 15:47:25 2013 (r27743)
>> +++ trunk/ompi/runtime/ompi_module_exchange.h 2013-01-04 15:50:25 EST (Fri, 04 Jan 2013) (r27744)
>> @@ -191,11 +191,6 @@
>> const ompi_proc_t *source_proc,
>> void **buffer, size_t *size);
>>
>> -
>> -OMPI_DECLSPEC int ompi_modex_recv_pointer(const mca_base_component_t *component,
>> - const ompi_proc_t *proc,
>> - void **buffer, opal_data_type_t type);
>> -
>> /**
>> * Receive a buffer from a given peer
>> *
>> _______________________________________________
>> svn mailing list
>> svn_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>