Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Compile-time MPI_Datatype checking
From: Dmitri Gribenko (gribozavr_at_[hidden])
Date: 2012-10-28 10:28:53


On Sun, Oct 28, 2012 at 3:51 PM, Jeff Squyres <jsquyres_at_[hidden]> wrote:
> On Oct 26, 2012, at 12:48 PM, Dmitri Gribenko wrote:
>
>> Thank you for reviewing and helping me to get this up to the project's
>> standards!
>
> Thank *you*.
>
> My prior reviews were from reading the code only. I just tried a few compile tests and got the following:
>
> 1. With gcc 4.4.6, I got a bunch of these:
>
> -----
> ../../../ompi/include/mpi.h:997: warning: ISO C90 does not support complex types
> ../../../ompi/include/mpi.h:998: warning: ISO C90 does not support complex types
> -----
>
> 2. With clang 3.1, I got a bunch of these:
>
> -----
> ../../../ompi/include/mpi.h:1084:5: warning: 'OMPI_HAVE_FORTRAN_COMPLEX8' is not defined, evaluates to 0 [-Wundef]
> #if OMPI_HAVE_FORTRAN_COMPLEX8
> ^
> ../../../ompi/include/mpi.h:1089:5: warning: 'OMPI_HAVE_FORTRAN_COMPLEX16' is not defined, evaluates to 0 [-Wundef]
> #if OMPI_HAVE_FORTRAN_COMPLEX16
> ^
> ../../../ompi/include/mpi.h:1094:5: warning: 'OMPI_HAVE_FORTRAN_COMPLEX32' is not defined, evaluates to 0 [-Wundef]
> #if OMPI_HAVE_FORTRAN_COMPLEX32
> ^
> -----

Thank you for the feedback! Hopefully the attached patch fixes both of these.

1. There are two helper structs with complex numbers. I predicated
the struct declarations and use to appear only in C99.

2. These macros were indeed missing.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr_at_[hidden]>*/