Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Compile-time MPI_Datatype checking
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2012-10-28 09:51:41


On Oct 26, 2012, at 12:48 PM, Dmitri Gribenko wrote:

> Thank you for reviewing and helping me to get this up to the project's
> standards!

Thank *you*.

My prior reviews were from reading the code only. I just tried a few compile tests and got the following:

1. With gcc 4.4.6, I got a bunch of these:

-----
../../../ompi/include/mpi.h:997: warning: ISO C90 does not support complex types
../../../ompi/include/mpi.h:998: warning: ISO C90 does not support complex types
-----

2. With clang 3.1, I got a bunch of these:

-----
../../../ompi/include/mpi.h:1084:5: warning: 'OMPI_HAVE_FORTRAN_COMPLEX8' is not defined, evaluates to 0 [-Wundef]
#if OMPI_HAVE_FORTRAN_COMPLEX8
    ^
../../../ompi/include/mpi.h:1089:5: warning: 'OMPI_HAVE_FORTRAN_COMPLEX16' is not defined, evaluates to 0 [-Wundef]
#if OMPI_HAVE_FORTRAN_COMPLEX16
    ^
../../../ompi/include/mpi.h:1094:5: warning: 'OMPI_HAVE_FORTRAN_COMPLEX32' is not defined, evaluates to 0 [-Wundef]
#if OMPI_HAVE_FORTRAN_COMPLEX32
    ^
-----

3. PGI and Intel seemed to have no problem with the patch (no extra warnings displayed during compilation).

Could you fix the issues with #1 and #2?

(to tie off the thread for the web archives: Dimitri did, in fact, submit an OMPI 3rd party contrib a while ago -- w00t! We're discussing logistics off-list)

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/