Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27451 - in trunk: ompi/mca/allocator/bucket ompi/mca/bcol/basesmuma ompi/mca/bml/base ompi/mca/btl ompi/mca/btl/base ompi/mca/btl/openib ompi/mca/btl/sm ompi/mca/btl/smcuda ompi/mca/btl/template ompi/mca/btl/va...
From: Ralph Castain (rhc_at_[hidden])
Date: 2012-10-22 11:43:32


Ah, I see - I checked and I don't see any unusual behavior in ompi_info or in picking up the params in components, so it looks like it didn't matter.

On Oct 22, 2012, at 8:04 AM, "Hjelm, Nathan T" <hjelmn_at_[hidden]> wrote:

> The change was due to the removal of the deprecated functions in mca_base_param. Comments in the command line parser suggested the change was expected eventually:
>
> 179 struct opal_cmd_line_init_t {
> 180 /** If want to set an MCA parameter, set its type name here.
> 181 WARNING: This MCA tuple (type, component, param) will
> 182 eventually be replaced with a single name! */
> 183 const char *ocl_mca_type_name;
> 184 /** If want to set an MCA parameter, set its component name
> 185 here. WARNING: This MCA tuple (type, component, param)
> 186 will eventually be replaced with a single name! */
> 187 const char *ocl_mca_component_name;
> 188 /** If want to set an MCA parameter, set its parameter name
> 189 here. WARNING: This MCA tuple (type, component, param)
> 190 will eventually be replaced with a single name! */
> 191 const char *ocl_mca_param_name;
>
> -Nathan
>
> ________________________________________
> From: devel-bounces_at_[hidden] [devel-bounces_at_[hidden]] on behalf of Ralph Castain [rhc_at_[hidden]]
> Sent: Thursday, October 18, 2012 5:48 PM
> To: devel_at_[hidden]
> Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r27451 - in trunk: ompi/mca/allocator/bucket ompi/mca/bcol/basesmuma ompi/mca/bml/base ompi/mca/btl ompi/mca/btl/base ompi/mca/btl/openib ompi/mca/btl/sm ompi/mca/btl/smcuda ompi/mca/btl/template ompi/mca/btl/va...
>
> Hmmm...this didn't just remove deprecated functions. It actually changed the way the cmd line parser works. Was that intentional?
>
> I haven't fully grok'd what that did to us, but wonder if the change was intentional or just got caught in the commit?
>
>
> On Oct 17, 2012, at 1:17 PM, svn-commit-mailer_at_[hidden] wrote:
>
>> Author: hjelmn (Nathan Hjelm)
>> Date: 2012-10-17 16:17:37 EDT (Wed, 17 Oct 2012)
>> New Revision: 27451
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27451
>>
>> Log:
>> MCA: remove deprecated mca_base_param functions (mca_base_param_register_int, mca_base_param_register_string, mca_base_param_environ_variable). Remove all uses of deprecated functions.
>> cmr:v1.7
>>
>> Text files modified:
>> trunk/ompi/mca/allocator/bucket/allocator_bucket.c | 5
>> trunk/ompi/mca/bcol/basesmuma/bcol_basesmuma_component.c | 7
>> trunk/ompi/mca/bml/base/bml_base_open.c | 22 +--
>> trunk/ompi/mca/btl/base/btl_base_open.c | 10 +-
>> trunk/ompi/mca/btl/btl.h | 4
>> trunk/ompi/mca/btl/openib/btl_openib_component.c | 8 +
>> trunk/ompi/mca/btl/sm/btl_sm_component.c | 14 ++
>> trunk/ompi/mca/btl/smcuda/btl_smcuda_component.c | 14 ++
>> trunk/ompi/mca/btl/template/btl_template_component.c | 14 ++
>> trunk/ompi/mca/btl/vader/btl_vader_component.c | 14 +-
>> trunk/ompi/mca/btl/wv/btl_wv_component.c | 6
>> trunk/ompi/mca/coll/demo/coll_demo_component.c | 8 +
>> trunk/ompi/mca/coll/ml/coll_ml_component.c | 19 ---
>> trunk/ompi/mca/coll/self/coll_self_component.c | 3
>> trunk/ompi/mca/pml/base/pml_base_bsend.c | 5
>> trunk/ompi/mca/pml/bfo/pml_bfo_component.c | 6
>> trunk/ompi/mca/pml/csum/pml_csum_component.c | 6
>> trunk/ompi/mca/pml/dr/pml_dr_component.c | 6
>> trunk/ompi/mca/pml/example/pml_example_component.c | 6
>> trunk/ompi/mca/pml/ob1/pml_ob1_component.c | 6
>> trunk/ompi/mca/pml/v/pml_v_component.c | 12 +
>> trunk/ompi/mca/sbgp/basesmsocket/sbgp_basesmsocket_component.c | 7 +
>> trunk/ompi/mca/sbgp/basesmuma/sbgp_basesmuma_component.c | 7 +
>> trunk/ompi/mca/sbgp/ibnet/sbgp_ibnet_component.c | 9 -
>> trunk/ompi/mca/sbgp/p2p/sbgp_p2p_component.c | 7 +
>> trunk/ompi/mca/vprotocol/example/vprotocol_example_component.c | 7 +
>> trunk/ompi/mca/vprotocol/pessimist/vprotocol_pessimist_component.c | 14 ++
>> trunk/ompi/tools/ompi-server/ompi-server.c | 10 +-
>> trunk/opal/dss/dss_open_close.c | 19 +--
>> trunk/opal/mca/base/mca_base_cmd_line.c | 4
>> trunk/opal/mca/base/mca_base_components_open.c | 11 +
>> trunk/opal/mca/base/mca_base_param.c | 96 --------------------
>> trunk/opal/mca/base/mca_base_param.h | 136 +---------------------------
>> trunk/opal/mca/shmem/base/shmem_base_select.c | 3
>> trunk/opal/tools/opal-checkpoint/opal-checkpoint.c | 14 +-
>> trunk/opal/tools/opal-restart/opal-restart.c | 18 +-
>> trunk/opal/util/cmd_line.c | 8 -
>> trunk/opal/util/cmd_line.h | 11 --
>> trunk/orte/mca/ess/base/ess_base_put.c | 6
>> trunk/orte/mca/ess/pmi/ess_pmi_module.c | 2
>> trunk/orte/mca/odls/base/odls_base_default_fns.c | 36 +++---
>> trunk/orte/mca/odls/default/odls_default_module.c | 5
>> trunk/orte/mca/plm/base/plm_base_launch_support.c | 6
>> trunk/orte/mca/plm/tm/plm_tm_module.c | 2
>> trunk/orte/orted/orted_main.c | 48 +++++-----
>> trunk/orte/tools/orte-checkpoint/orte-checkpoint.c | 28 +++---
>> trunk/orte/tools/orte-clean/orte-clean.c | 8
>> trunk/orte/tools/orte-migrate/orte-migrate.c | 16 +-
>> trunk/orte/tools/orte-ps/orte-ps.c | 16 +-
>> trunk/orte/tools/orte-restart/orte-restart.c | 24 ++--
>> trunk/orte/tools/orte-top/orte-top.c | 18 +-
>> trunk/orte/tools/orterun/orterun.c | 186 +++++++++++++++++++--------------------
>> trunk/orte/util/pre_condition_transports.c | 2
>> 53 files changed, 390 insertions(+), 589 deletions(-)
>>
>>
>> Diff not shown due to size (102218 bytes).
>> To see the diff, run the following command:
>>
>> svn diff -r 27450:27451 --no-diff-deleted
>>
>> _______________________________________________
>> svn mailing list
>> svn_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel