Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] RFC: hide btl segment keys within btl
From: Rolf vandeVaart (rvandevaart_at_[hidden])
Date: 2012-06-18 13:18:20


Hi Nathan:
I downloaded and tried it out. There were a few issues that I had to work through, but finally got things working.
Can you apply this patch to your changes prior to checking things in?

I also would suggest configuring with --enable-picky as there are something like 10 warnings generated due to your changes. And check for tabs.

Otherwise, I think it is good.

Rolf

>-----Original Message-----
>From: devel-bounces_at_[hidden] [mailto:devel-bounces_at_[hidden]]
>On Behalf Of George Bosilca
>Sent: Saturday, June 16, 2012 12:49 PM
>To: Open MPI Developers
>Subject: Re: [OMPI devel] RFC: hide btl segment keys within btl
>
>Looks good to me. I would add some checks regarding the number and size of
>the segments and the allocated space (MCA_BTL_SEG_MAX_SIZE) to make
>sure we never hit the corner case where there are too many segments
>compared with the available space. And add a huge comment in the btl.h
>about the fact that mca_btl_base_segment_t should be used with extreme
>care.
>
> george.
>
>On Jun 14, 2012, at 18:42 , Jeff Squyres wrote:
>
>> This sounds like a good thing to me. +1
>>
>> On Jun 13, 2012, at 12:58 PM, Nathan Hjelm wrote:
>>
>>> What: hide btl segment keys from PML/OSC code.
>>>
>>> Why: As it stands new BTLs with larger segment keys (smcuda for example)
>require changes in both OSC/rdma as well as the PMLs. This RFC makes will
>make changes in segment keys transparent to all btl users.
>>>
>>> When: The changes are very straight-forward so I am setting the timeout
>for this to June 22, 2012
>>>
>>> Where: See the attached patch or check out the bitbucket
>http://bitbucket.org/hjelmn/ompi-btl-interface-update
>>>
>>> All the relevant PMLs/BTLs + OSC/rdma have been updated with the
>exception of btl/wv. I have also tested the following components:
>>> - ob1
>>> - csum
>>> - bfo
>>> - ugni (now works with MPI one-sides)
>>> - sm
>>> - vader
>>> - openib (in progress)
>>>
>>> Brian and Rolf, please take a look at your components and let me know if I
>screwed anything up.
>>>
>>> -Nathan Hjelm
>>> HPC-3, LANL
>>> _______________________________________________
>>> devel mailing list
>>> devel_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>>
>> --
>> Jeff Squyres
>> jsquyres_at_[hidden]
>> For corporate legal information go to:
>http://www.cisco.com/web/about/doing_business/legal/cri/
>>
>>
>> _______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
>
>_______________________________________________
>devel mailing list
>devel_at_[hidden]
>http://www.open-mpi.org/mailman/listinfo.cgi/devel

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------