Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [EXTERNAL] Re: [OMPI svn] svn:open-mpi r25966
From: Ralph Castain (rhc_at_[hidden])
Date: 2012-02-20 18:24:29


It looks okay, Jeff - I ran make diet and all the headers are in the resulting tarball.

On Feb 20, 2012, at 4:03 PM, Jeffrey Squyres wrote:

> FWIW, I think we're still going to have another problem with "make dist" -- some of the Java header files are generated. I'm not sure we have that right in the Makefile.am.
>
> I committed this fbtl fix; I'll try "make dist" now, but I have to run for a while. I may or may not get this done by the tarball generation tonight.
>
>
> On Feb 20, 2012, at 5:59 PM, Jeffrey Squyres wrote:
>
>> Added… thanks.
>>
>>
>> On Feb 20, 2012, at 5:41 PM, Barrett, Brian W wrote:
>>
>>> That's because Jeff forgot to copy the line:
>>>
>>> AC_CONFIG_FILES([ompi/mca/fbtl/posix/Makefile])
>>>
>>>> From whatever configure.m4 script he used as the base for his new macro :).
>>>
>>> Brian
>>>
>>> On 2/20/12 3:36 PM, "Ralph Castain" <rhc_at_[hidden]> wrote:
>>>
>>>> I'm afraid this commit breaks the ability to build from a tarball. I
>>>> created a tarball from the trunk and then did a configure followed by
>>>> "make clean". The make command failed to execute because it could not
>>>> "make clean" in the mca/fbtl/posix directory as there is no Makefile in
>>>> it.
>>>>
>>>> I checked and the Makefile -is- being created when built in an svn
>>>> checkout, but is -not- being created when built from tarball. This was
>>>> done on a Mac.
>>>>
>>>>
>>>> On Feb 20, 2012, at 8:53 AM, jsquyres_at_[hidden] wrote:
>>>>
>>>>> Author: jsquyres
>>>>> Date: 2012-02-20 10:53:20 EST (Mon, 20 Feb 2012)
>>>>> New Revision: 25966
>>>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/25966
>>>>>
>>>>> Log:
>>>>> Ensure that we have aio.h before trying to compile this component.
>>>>>
>>>>> Added:
>>>>> trunk/ompi/mca/fbtl/posix/configure.m4
>>>>>
>>>>> Added: trunk/ompi/mca/fbtl/posix/configure.m4
>>>>>
>>>>> =========================================================================
>>>>> =====
>>>>> --- (empty file)
>>>>> +++ trunk/ompi/mca/fbtl/posix/configure.m4 2012-02-20 10:53:20 EST
>>>>> (Mon, 20 Feb 2012)
>>>>> @@ -0,0 +1,33 @@
>>>>> +# -*- shell-script -*-
>>>>> +#
>>>>> +# Copyright (c) 2004-2005 The Trustees of Indiana University and
>>>>> Indiana
>>>>> +# University Research and Technology
>>>>> +# Corporation. All rights reserved.
>>>>> +# Copyright (c) 2004-2005 The University of Tennessee and The
>>>>> University
>>>>> +# of Tennessee Research Foundation. All rights
>>>>> +# reserved.
>>>>> +# Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
>>>>> +# University of Stuttgart. All rights
>>>>> reserved.
>>>>> +# Copyright (c) 2004-2012 The Regents of the University of California.
>>>>> +# All rights reserved.
>>>>> +# Copyright (c) 2010 Cisco Systems, Inc. All rights reserved.
>>>>> +# Copyright (c) 2008-2011 University of Houston. All rights reserved.
>>>>> +# $COPYRIGHT$
>>>>> +#
>>>>> +# Additional copyrights may follow
>>>>> +#
>>>>> +# $HEADER$
>>>>> +#
>>>>> +
>>>>> +# MCA_fbtl_posix_CONFIG(action-if-can-compile,
>>>>> +# [action-if-cant-compile])
>>>>> +# ------------------------------------------------
>>>>> +AC_DEFUN([MCA_ompi_fbtl_posix_CONFIG],[
>>>>> + AC_CHECK_HEADER([aio.h],
>>>>> + [fbtl_posix_happy="yes"],
>>>>> + [fbtl_posix_happy="no"])
>>>>> +
>>>>> + AS_IF([test "$fbtl_posix_happy" = "yes"],
>>>>> + [$1],
>>>>> + [$2])
>>>>> +])dnl
>>>>> _______________________________________________
>>>>> svn mailing list
>>>>> svn_at_[hidden]
>>>>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>>>>
>>>>
>>>> _______________________________________________
>>>> devel mailing list
>>>> devel_at_[hidden]
>>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>>>
>>>>
>>>
>>>
>>> --
>>> Brian W. Barrett
>>> Dept. 1423: Scalable System Software
>>> Sandia National Laboratories
>>>
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> devel mailing list
>>> devel_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>>
>> --
>> Jeff Squyres
>> jsquyres_at_[hidden]
>> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
>>
>>
>> _______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
>
> --
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel