Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] non-portable test operator in configure
From: Jeffrey Squyres (jsquyres_at_[hidden])
Date: 2012-02-20 16:39:46


Committed -- thanks.

Confirmed that it's not in v1.5, too. Just for good measure.

On Feb 20, 2012, at 4:12 PM, Paul H. Hargrove wrote:

> Not what I had expected to find, but a pretty simple fix (missing line continuation):
>
> Index: orte/mca/ess/alps/configure.m4
> ===================================================================
> --- orte/mca/ess/alps/configure.m4 (revision 25970)
> +++ orte/mca/ess/alps/configure.m4 (working copy)
> @@ -53,7 +53,7 @@
> [orte_mca_ess_alps_happy="yes"],
> [orte_mca_ess_alps_happy="no"])
>
> - AS_IF([test "$orte_mca_ess_alps_happy" = "yes" -a "$orte_without_full_support" = 0 -a
> + AS_IF([test "$orte_mca_ess_alps_happy" = "yes" -a "$orte_without_full_support" = 0 -a \
> "$orte_mca_ess_alps_have_cnos" = 1],
> [$1],
> [$2])
>
>
> That is sufficient to let "dash" on an Ubuntu system make it through configure.
> I'll report back ASAP on my slowlaris10 results.
>
> NOTE: this is NOT present in the v1.5 branch (no cmr is required).
>
> -Paul
>
> On 2/20/2012 12:46 PM, Jeffrey Squyres wrote:
>> Ah, ok.
>>
>> On Feb 20, 2012, at 3:45 PM, Paul H. Hargrove wrote:
>>
>>> Jeff,
>>>
>>> The one in config/ompi_load_platform.m4 was on my original hit-list.
>>> Getting PAST that one shows a new problem that appears NOT to be a "==".
>>> The autoconf manual warns about use of "-a" and "-o" together with variables that may expand to the empty string, and I suspect that is the new problem I am hitting. I hope to know soon.
>>>
>>> -Paul
>>>
>>>
>>> On 2/20/2012 12:41 PM, Jeffrey Squyres wrote:
>>>> grep == configure | grep test
>>>>
>>>> only shows one more. I found it in config/ompi_load_platform.m4 and fixed it on the trunk.
>>>>
>>>>
>>>> On Feb 20, 2012, at 3:38 PM, Paul H. Hargrove wrote:
>>>>
>>>>> I am afraid that with the $with_platform instance fixed, configure on Solaris 10 gets far enough to find another problem.
>>>>> I'll provide a patch once I've tracked this down. Sigh.
>>>>>
>>>>> FYI:
>>>>> One can root out bashisms by using the "dash" shell on a Debian or Ubuntu system:
>>>>> $ env CONFIG_SHELL=dash dash [path_to]/configure [options]
>>>>>
>>>>> -Paul
>>>>>
>>>>>
>>>>>
>>>>> On 2/20/2012 5:42 AM, Jeffrey Squyres wrote:
>>>>>> Fixed -- thanks!
>>>>>>
>>>>>> On Feb 20, 2012, at 4:11 AM, Paul H. Hargrove wrote:
>>>>>>
>>>>>>> Please note that "==" is NOT a portable binary operator for the "test" utility.
>>>>>>> It is supported only by the bash built-in version of "test".
>>>>>>> The correct operator is a simple "=".
>>>>>>>
>>>>>>> The following appear in the svn trunk
>>>>>>>
>>>>>>> ./orte/config/orte_check_alps.m4: AS_IF([test "$orte_check_alps_pmi_happy" == "yes" -a "$orte_without_full_support" = 0],
>>>>>>> ./config/ompi_load_platform.m4: if test "$with_platform" == "" ; then
>>>>>>>
>>>>>>> The $with_platform test breaks configure fairly early on at least Solaris 10.
>>>>>>>
>>>>>>> -Paul
>>>>>>>
>>>>>>> --
>>>>>>> Paul H. Hargrove PHHargrove_at_[hidden]
>>>>>>> Future Technologies Group
>>>>>>> HPC Research Department Tel: +1-510-495-2352
>>>>>>> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> devel mailing list
>>>>>>> devel_at_[hidden]
>>>>>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>>>> --
>>>>> Paul H. Hargrove PHHargrove_at_[hidden]
>>>>> Future Technologies Group
>>>>> HPC Research Department Tel: +1-510-495-2352
>>>>> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
>>>>>
>>>>> _______________________________________________
>>>>> devel mailing list
>>>>> devel_at_[hidden]
>>>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>> --
>>> Paul H. Hargrove PHHargrove_at_[hidden]
>>> Future Technologies Group
>>> HPC Research Department Tel: +1-510-495-2352
>>> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
>>>
>>> _______________________________________________
>>> devel mailing list
>>> devel_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>
> --
> Paul H. Hargrove PHHargrove_at_[hidden]
> Future Technologies Group
> HPC Research Department Tel: +1-510-495-2352
> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/