Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] 1.4.5rc4: opal_path_nfs() ALMOST fixed
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2012-01-31 15:25:27


On Jan 31, 2012, at 3:18 PM, Paul H. Hargrove wrote:

> Looks like you /almost/ got it this time.
>
> For opal/util/path.c you only fixed 1 out of 3 instances of defined(linux).
> So, now it fails to compile ('buf' is undefined) rather than failing one test at "make check".

Crud. Missed the others. :-(

> And, by the way the fix you did apply:
> "defined(linux) || defined(__linux) || defined(__linux__)"
> is probably overkill.

Yea, I know. :-)

> As I had noted toward the bottom of http://www.open-mpi.org/community/lists/devel/2012/01/10268.php , there are many instances of "defined(__linux__)" that seem to work fine. So, that alone should be fine.

Ok.

> -Paul
>
> On 1/31/2012 11:21 AM, Jeff Squyres wrote:
>> Hot on the heels of rc3, rc4 is out:
>>
>> http://www.open-mpi.org/software/ompi/v1.4/
>>
>> The main differences are the 8 issues that Paul Hargrove mentioned:
>>
>> Make v1.4 configure fail on OS X 10.3 and earlier
>>
>> Fix opal/util/path.c for Linux with old compilers
>>
>> README updates for the Sun compilers
>>
>> README updates noting systems that are no longer supported
>>
>> Fix assembly generation code on BSD in v1.4
>>
>
> --
> Paul H. Hargrove PHHargrove_at_[hidden]
> Future Technologies Group
> HPC Research Department Tel: +1-510-495-2352
> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/