Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Incorrect and undefined return code/function/data type at C++ header
From: Y.MATSUMOTO (yuki.matsumoto_at_[hidden])
Date: 2011-12-08 21:35:31


Dear Jeff and all,

Thank you for your comment.
I'm sorry for not replying sooner.

1:MPI::Fint
We checked C++ header using MPI-2.1 standard.
So, it doesn't need MPI::Fint definition.
(Please remove it!)

2:MPI::Grequest::Start
Sorry! I send you incorrect list.

Best regards.
---------------
Yuki MATSUMOTO
MPI development team,
Fujitsu

(2011/12/06 1:35), Jeff Squyres wrote:
> Many thanks for the patch!
>
> Two minor points:
>
> 1. I do not believe that MPI::Fint exists. It's surprising, but I'm pretty sure we double checked this back in the MPI-2.2 timeframe and came to the conclusions that a) it does not exist, and b) it should not exist, because all C++<--> Fortran interaction is supposed to go through the C translation routines.
>
> 2. Grequest::Start is a static function on the MPI namespace -- it is not marked "const" in MPI 2.1 or 2.2 (I don't see it in the patch, either).
>
> On Dec 4, 2011, at 9:31 PM, Y.MATSUMOTO wrote:
>
>> Dear all,
>>
>> We send next feed back.
>> It's about C++ header file.
>>
>> In ompi/mpi/cxx/*.h,
>> Some definitions of return code, type and function are lacked or incorrect.
>> Attached patch fixes them (This Patch is for V1.4.X).
>>
>> Following list is what is lacked and incorrect.
>>
>> *Undefined return code
>> --------------------------------------------------
>> MPI::ERR_ACCESS
>> MPI::ERR_AMODE
>> MPI::ERR_ASSERT
>> MPI::ERR_BAD_FILE
>> MPI::ERR_CONVERSION
>> MPI::ERR_DISP
>> MPI::ERR_DUP_DATAREP
>> MPI::ERR_FILE_EXISTS
>> MPI::ERR_FILE_IN_USE
>> MPI::ERR_FILE
>> MPI::ERR_INFO
>> MPI::ERR_IO
>> MPI::ERR_LOCKTYPE
>> MPI::ERR_NOT_SAME
>> MPI::ERR_NO_SPACE
>> MPI::ERR_NO_SUCH_FILE
>> MPI::ERR_PORT
>> MPI::ERR_QUOTA
>> MPI::ERR_READ_ONLY
>> MPI::ERR_RMA_CONFLICT
>> MPI::ERR_RMA_SYNC
>> MPI::ERR_SIZE
>> MPI::ERR_UNSUPPORTED_DATAREP
>> MPI::ERR_UNSUPPORTED_OPERATION
>> --------------------------------------------------
>> *Undefined data type
>> --------------------------------------------------
>> MPI::LONG_LONG_INT
>> MPI::Fint
>> MPI::F_DOUBLE_COMPLEX
>> --------------------------------------------------
>>
>> *Undefined function
>> --------------------------------------------------
>> MPI::Datatype::Create_darray
>> MPI::Datatype::Pack_external
>> MPI::Datatype::Pack_external_size
>> MPI::Datatype::Unpack_external
>> MPI::Add_error_class
>> MPI::Add_error_code
>> MPI::Add_error_string
>> MPI::Datatype::Create_f90_complex
>> MPI::Datatype::Create_f90_integer
>> MPI::Datatype::Create_f90_real
>> MPI::Datatype::Match_size
>> --------------------------------------------------
>>
>> *Incorrect of definitions
>> (MPI-2.1 standard defines these as "const", but they are not "const" in code)
>> --------------------------------------------------
>> MPI::Intercomm::Merge
>> MPI::Cartcomm::Sub
>> MPI::Grequest::Start
>> --------------------------------------------------
>>
>> *Incorrect of definitions
>> (MPI-2.1 standard defines these as not "const", but they are "const" in code)
>> --------------------------------------------------
>> MPI::Comm::Set_errhandler
>> MPI::File::Set_errhandler
>> MPI::Win::Set_errhandler
>> --------------------------------------------------
>>
>> Best regards.
>> --------------
>> Yuki MATSUMOTO
>> MPI development team,
>> Fujitsu
>>
>> <Cplusplus-header.patch>_______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
>