Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Fix a hang in carto_base_select() if carto_module_init() fails
From: nadia.derbey_at_[hidden]
Date: 2011-07-08 04:13:32


Yes, sure! Agreed.

Regards,

--
Nadia Derbey
Phone: +33 (0)4 76 29 77 62
devel-bounces_at_[hidden] wrote on 07/08/2011 02:10:22 AM:
> De : Jeff Squyres <jsquyres_at_[hidden]>
> A : Open MPI Developers <devel_at_[hidden]>
> Date : 07/08/2011 02:10 AM
> Objet : Re: [OMPI devel] Fix a hang in carto_base_select() if 
> carto_module_init() fails
> Envoyé par : devel-bounces_at_[hidden]
> 
> I'd go even slightly simpler than that:
> 
> Index: opal/mca/carto/base/carto_base_select.c
> ===================================================================
> --- opal/mca/carto/base/carto_base_select.c   (revision 24842)
> +++ opal/mca/carto/base/carto_base_select.c   (working copy)
> @@ -64,10 +64,7 @@
>  cleanup:
>      /* Initialize the winner */
>      if (NULL != opal_carto_base_module) {
> -        if (OPAL_SUCCESS != (ret = 
> opal_carto_base_module->carto_module_init()) ) {
> -            exit_status = ret;
> -            goto cleanup;
> -        }
> +        exit_status = opal_carto_base_module->carto_module_init();
>      }
> 
>      return exit_status;
> 
> 
> 
> On Jun 28, 2011, at 3:02 AM, nadia.derbey wrote:
> 
> > Hi,
> > 
> > When using the carto/file module with a syntactically incorrect carto
> > file, we get stuck into opal_carto_base_select().
> > 
> > The attached trivial patch fixes the issue.
> > 
> > Regards,
> > Nadia
> > 
> > 
> > -- 
> > nadia.derbey <Nadia.Derbey_at_[hidden]>
> > 
<carto_base_select.patch>_______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 
> 
> -- 
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/
> 
> 
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel