Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r24836
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2011-06-29 10:59:30


That's still not quite right, per OMPI conventions.

If you don't find it, you shouldn't warn, you should have some other AC_MSG_CHECKING and then indicate that that particular check failed.

E.g.

AC_MSG_CHECKING([if can use dynamic SL support])
AS_IF([test "$1_have_dynamic_sl" = "1"],
      [AC_MSG_RESULT([yes])],
      [AC_MSG_RESULT([no])
       AS_IF([test "$enable_openib_dynamic_sl" = "yes"],
             [AC_MSG_WARN([--enable-openib-dynamic-sl was specified but the])
              AC_MSG_WARN([appropriate header files could not be found.])
              AC_MSG_ERROR([Cannot continue])])
      ])

(I just typed that in my mail client; I don't know if all the [] and () match properly)

On Jun 29, 2011, at 10:52 AM, kliteyn_at_[hidden] wrote:

> Author: kliteyn
> Date: 2011-06-29 10:52:11 EDT (Wed, 29 Jun 2011)
> New Revision: 24836
> URL: https://svn.open-mpi.org/trac/ompi/changeset/24836
>
> Log:
> Changed default behavior when opensm-devel pachege not found - warn, not exit
>
>
> Text files modified:
> trunk/ompi/config/ompi_check_openib.m4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Modified: trunk/ompi/config/ompi_check_openib.m4
> ==============================================================================
> --- trunk/ompi/config/ompi_check_openib.m4 (original)
> +++ trunk/ompi/config/ompi_check_openib.m4 2011-06-29 10:52:11 EDT (Wed, 29 Jun 2011)
> @@ -195,7 +195,7 @@
> # ib_types.h, but it doesn't include any other IB-related files.
> AC_CHECK_HEADER([infiniband/complib/cl_types_osd.h],
> [$1_have_dynamic_sl=1],
> - [AC_MSG_ERROR([opensm-devel package not found - please install it or disable dynamic SL support with \"--disable-openib-dynamic-sl\"])],
> + [AC_MSG_WARN([opensm-devel package not found - please install it or disable dynamic SL support with \"--disable-openib-dynamic-sl\"])],
> [])
> fi
>
> _______________________________________________
> svn-full mailing list
> svn-full_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/