Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r24449
From: Barrett, Brian W (bwbarre_at_[hidden])
Date: 2011-02-23 17:15:41


George -

You're right, I misread the patch. I've run into the same issue with gcc
before, but not on x86.

Jay, can you point us to the original bug report? I couldn't figure out
how to get from the patch to the bug in your bugzilla.

Brian

On 2/23/11 2:57 PM, "George Bosilca" <bosilca_at_[hidden]> wrote:

>If I understand correctly the assembly this change is not related to
>clobber, but to the input register. Moreover, I don't think the patch is
>correct. More to come...
>
> george.
>
>
>On Feb 23, 2011, at 16:54 , brbarret_at_[hidden] wrote:
>
>> Author: brbarret
>> Date: 2011-02-23 16:54:07 EST (Wed, 23 Feb 2011)
>> New Revision: 24449
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/24449
>>
>> Log:
>> Fix register clobber list for x86 assembly. Thanks to Jay Fenlason for
>>the
>> patch.
>>
>> Text files modified:
>> trunk/opal/config/opal_config_asm.m4 | 2 +-
>>
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> Modified: trunk/opal/config/opal_config_asm.m4
>>
>>=========================================================================
>>=====
>> --- trunk/opal/config/opal_config_asm.m4 (original)
>> +++ trunk/opal/config/opal_config_asm.m4 2011-02-23 16:54:07 EST
>>(Wed, 23 Feb 2011)
>> @@ -867,7 +867,7 @@
>> ompi_cv_asm_arch="AMD64"
>> fi
>> OPAL_ASM_SUPPORT_64BIT=1
>> - OMPI_GCC_INLINE_ASSIGN='"xaddl %1,%0" : "=m"(ret),
>>"+r"(negone)'
>> + OMPI_GCC_INLINE_ASSIGN='"xaddl %1,%0" : "=m"(ret),
>>"+r"(negone) : "m"(ret)'
>> ;;
>>
>> ia64-*)
>> _______________________________________________
>> svn-full mailing list
>> svn-full_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>
>"I disapprove of what you say, but I will defend to the death your right
>to say it"
> -- Evelyn Beatrice Hall
>
>
>_______________________________________________
>devel mailing list
>devel_at_[hidden]
>http://www.open-mpi.org/mailman/listinfo.cgi/devel
>