Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767
From: Barrett, Brian W (bwbarre_at_[hidden])
Date: 2010-09-20 11:48:10


Jeff -

Sorry, was out of town last week. The patch undoes the discussion we had -- we always run component macros, even if the component couldn't build, to solve the issue of AC_CONFIG_FILES needing to always be run. So the first part of the patch is incorrect and should not be committed. We might need to make the valgrind configure.m4 macro smarter, but the other option is really painful.

I think the second issue is a typo and can be changed. Originally, I think we needed to know whether the component configure failed or the component was told not to build, but that no longer seems necessary.

Brian

On Sep 18, 2010, at 9:48 AM, Jeff Squyres wrote:

> On Sep 18, 2010, at 4:54 PM, Ralph Castain wrote:
>
>> Good point - nothing secret about it!
>
> Yes, nothing secret, but it's kinda deep in our ompi_mca.m4 file. I'm not quite sure why Brian removed the AS_IF clause when we did the changes; I don't know if he had a deep reason for it or not. But it seems like we clearly need it because the memcheck framework tries to disable itself by setting $DISABLE_memcheck=1 if you don't --enable-memcheck.
>
> The new ompi_mca.m4 always calls MCA_$1_$2_$3_CONFIG (i.e., the component's config macro in its configure.m4 script) -- the old version checked $should_build first before calling it. I put the AS_IF back in the patch below.
>
>> Index: config/ompi_mca.m4
>> ===================================================================
>> --- config/ompi_mca.m4 (revision 23770)
>> +++ config/ompi_mca.m4 (working copy)
>> @@ -564,10 +564,12 @@
>>
>> # try to configure the component. pay no attention to
>> # --enable-dist, since we'll always have makefiles.
>> - m4_ifdef([MCA_$1_$2_$3_CONFIG],
>> + AS_IF([test "$should_build" = "1"],
>> + [m4_ifdef([MCA_$1_$2_$3_CONFIG],
>> [MCA_$1_$2_$3_CONFIG([should_build=$should_build],
>> [should_build=0])],
>> [m4_fatal([MCA_$1_$2_$3_CONFIG macro not found])])
>> + ])
>>
>> AS_IF([test "$should_build" = "1"],
>> [MCA_PROCESS_COMPONENT($1, $2, $3, $4, $5, $6, $7, $compile_mode)],
>> @@ -619,7 +621,7 @@
>> if test "$should_build" = "1" ; then
>> OMPI_CONFIG_SUBDIR([$1/mca/$2/$component],
>> [$ompi_subdir_args],
>> - [should_build=1], [should_build=2])
>> + [should_build=1], [should_build=0])
>
> This just looked like a typo.
>
> --
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

-- 
  Brian W. Barrett
  Dept. 1423: Scalable System Software
  Sandia National Laboratories