Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r23767
From: Ralph Castain (rhc_at_[hidden])
Date: 2010-09-18 03:19:42


Ha! I did that earlier too, but then realized that this error happens only when someone specifies they want-valigrind. I believe the issue here has been discussed before - if someone says "give me valgrind support", then we should error out if the required level isn't available.

yes?

You must still be overseas??

On Sep 18, 2010, at 1:14 AM, jsquyres_at_[hidden] wrote:

> Author: jsquyres
> Date: 2010-09-18 03:14:58 EDT (Sat, 18 Sep 2010)
> New Revision: 23767
> URL: https://svn.open-mpi.org/trac/ompi/changeset/23767
>
> Log:
> Make this a warning, not an error.
>
> Text files modified:
> trunk/opal/mca/memchecker/valgrind/configure.m4 | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> Modified: trunk/opal/mca/memchecker/valgrind/configure.m4
> ==============================================================================
> --- trunk/opal/mca/memchecker/valgrind/configure.m4 (original)
> +++ trunk/opal/mca/memchecker/valgrind/configure.m4 2010-09-18 03:14:58 EDT (Sat, 18 Sep 2010)
> @@ -9,6 +9,7 @@
> #
> # $HEADER$
> #
> +
> AC_DEFUN([MCA_opal_memchecker_valgrind_PRIORITY], [10])
>
> AC_DEFUN([MCA_opal_memchecker_valgrind_COMPILE_MODE], [
> @@ -49,7 +50,7 @@
> [AC_MSG_RESULT([yes])
> opal_memchecker_valgrind_happy=yes],
> [AC_MSG_RESULT([no])
> - AC_MSG_ERROR([Need Valgrind version 3.2.0 or later. Can not build component.])]
> + AC_MSG_WARN([Need Valgrind version 3.2.0 or later. Can not build component.])]
> [AC_MSG_RESULT([cross-compiling; assume yes...?])
> AC_MSG_WARN([OMPI will fail to compile if you do not have Valgrind version 3.2.0 or later])
> opal_memchecker_valgrind_happy=yes]),
> @@ -58,6 +59,10 @@
> AC_MSG_WARN([Cannot compile this component])])])
> CPPFLAGS="$opal_memchecker_valgrind_save_CPPFLAGS"
>
> + # If we specifically requested this component and can't build it, error
> + AS_IF([test "$with_valgrind" != "no" -a "$with_valgrind" != "" -a "$opal_memcheck_valgrind_happy" != "yes"],
> + [AC_MSG_ERROR([Cannot continue])])
> +
> AS_IF([test "$opal_memchecker_valgrind_happy" = "yes"],
> [$1],[$2])
>
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn