Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [PATCH] openmpi: get it built with newer autoconf
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2010-08-27 13:57:09


All instances will be fixed on the SVN trunk in a commit coming in a few hours (delaying autogen-worthy changes during the business day). Shame on us for using AS_VAR_GET.

CMR's for v1.5 coming tonight; CMR for v1.4 (because it's a different patch) is here:

    https://svn.open-mpi.org/trac/ompi/ticket/2559

Thanks!

On Aug 18, 2010, at 1:32 PM, Ralf Wildenhues wrote:

> Hello,
>
> * Jeff Squyres wrote on Wed, Aug 18, 2010 at 06:35:22PM CEST:
>>
>> With a quick grep, I actually see 16 uses of AS_VAR_GET. Do the other
>> 15 cases not cause problems?
>
> Whether or not, since AS_VAR_GET is undocumented (and inefficient,
> and now also buggy), it's prudent to replace them all with either
> AS_VAR_COPY or AS_VAR_IF as appropriate.
>
> Cheers,
> Ralf
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/