Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r23628
From: Wesley Bland (wbland_at_[hidden])
Date: 2010-08-19 14:01:28


So just to clarify, this means that we don't need to worry about having more
than one errmgr module handling a single failure and therefore don't have to
set the stack_state (which is now gone anyway). Am I reading this
correctly?

Thanks,
Wesley

On Thu, Aug 19, 2010 at 9:09 AM, <jjhursey_at_[hidden]> wrote:

> Author: jjhursey
> Date: 2010-08-19 09:09:20 EDT (Thu, 19 Aug 2010)
> New Revision: 23628
> URL: https://svn.open-mpi.org/trac/ompi/changeset/23628
>
> Log:
> Simplification of the ErrMgr framework by removing the 'stack'/composite
> functionality.
>
> The composite functionality was becoming difficult to maintain, so we
> removed it for now which simplifies the framework design considerably.
>
> Since the 'crmig' and 'autor' components were -very- similar to the 'hnp'
> component, this commit also merges them together. By moving the 'crmig' and
> 'autor' to a separate file under the 'hnp' component we are able to isolate
> the C/R logic to a large extent, thus being only minimally hooked into the
> previous 'hnp' component.
>
> So other than some name changes, the functionality is all still in place. I
> will update the C/R documentation later this morning.
>
>
> Added:
> trunk/orte/mca/errmgr/hnp/errmgr_hnp_autor.c
> trunk/orte/mca/errmgr/hnp/errmgr_hnp_crmig.c
> Removed:
> trunk/orte/mca/errmgr/autor/
> trunk/orte/mca/errmgr/crmig/
> trunk/orte/mca/errmgr/example/
> Text files modified:
> trunk/contrib/amca-param-sets/ft-enable-cr-recovery | 9
> trunk/orte/mca/errmgr/app/errmgr_app.c | 11
> trunk/orte/mca/errmgr/base/base.h | 16
> trunk/orte/mca/errmgr/base/errmgr_base_close.c | 25 -
> trunk/orte/mca/errmgr/base/errmgr_base_fns.c | 133 ------------
> trunk/orte/mca/errmgr/base/errmgr_base_open.c | 18
> trunk/orte/mca/errmgr/base/errmgr_base_select.c | 149 +------------
> trunk/orte/mca/errmgr/base/errmgr_base_tool.c | 2
> trunk/orte/mca/errmgr/base/errmgr_private.h | 19 -
> trunk/orte/mca/errmgr/errmgr.h | 180
> +++++-----------
> trunk/orte/mca/errmgr/hnp/Makefile.am | 4
> trunk/orte/mca/errmgr/hnp/errmgr_hnp.c | 426
> +++++++++++++++++++++++++++++----------
> trunk/orte/mca/errmgr/hnp/errmgr_hnp.h | 102 +++++++++
> trunk/orte/mca/errmgr/hnp/errmgr_hnp_component.c | 200
> ++++++++++++++---
> trunk/orte/mca/errmgr/hnp/help-orte-errmgr-hnp.txt | 29 ++
> trunk/orte/mca/errmgr/orted/errmgr_orted.c | 34 +-
> 16 files changed, 738 insertions(+), 619 deletions(-)
>
>
> Diff not shown due to size (166344 bytes).
> To see the diff, run the following command:
>
> svn diff -r 23627:23628 --no-diff-deleted
>
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>