Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] v1.5: thumbs up or down? - Thumbs Down
From: Kevin.Buckley_at_[hidden]
Date: 2010-07-11 00:25:05


> > OK, I humbly withdraw (a) above but now, equally humbly, suggest
> > that instead of using a list, those things be turned into standard,
> > single-target, configure options, vis:
> >
> > --with-XXXX=
> >
> > --enable-XXXX=
>
> True, this would be better. I believe that Brian didn't initially do it
> this way for some subtle reasons, but I confess that I don't remember
> exactly why.
>
> Patches would be welcome here. :-)
>
> --
> Jeff Squyres

Here you go, as per our offlist discussion, a patch that allows
one to deselect addons individually,

--enable-addon1=no --disable-addon3

which is required because you can't build up

--enable-contrib-no-build=addon1 --enable-contrib-no-build=addon2

options as the build system only honours the last one.

What this does is use the value of

--enable-addon1 (yes)
--enable-addon1=yes (yes)
--enable-addon1=no (no)
--disable-addon1 (no)

or sets it to "yes" if you don't give anything, thereby maintaining
the default of build all the contribs unless told otherwise.

$ diff -u openmpi-1.5rc3{-vanilla,}/config/ompi_contrib.m4
--- openmpi-1.5rc3-vanilla/config/ompi_contrib.m4 2009-12-09
10:33:28.000000000 +1300
+++ openmpi-1.5rc3/config/ompi_contrib.m4 2010-07-11
15:43:56.000000000 +1200
@@ -99,6 +99,16 @@

     ompi_show_subsubsubtitle "$1 (m4 configuration macro)"

+ AC_ARG_ENABLE([$1],
+ [AS_HELP_STRING([--disable-$1],
+ [disable support for contributed package $1])],
+ [],
+ [enable_$1=yes])
+
+ if test "x$enable_$1" != xyes ; then
+ DISABLE_contrib_$1=yes
+ fi
+
     OMPI_CONTRIB_HAPPY=0
     if test "$DISABLE_contrib_$1" = "" -a "$DISABLE_contrib_all" = ""; then

-- 
Kevin M. Buckley                                  Room:  CO327
School of Engineering and                         Phone: +64 4 463 5971
 Computer Science
Victoria University of Wellington
New Zealand