Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] v1.5: thumbs up or down?
From: Kevin.Buckley_at_[hidden]
Date: 2010-07-05 22:33:31


> 4) The other thing that comes to mind are the mountain of WARNINGs
> because of the "redefinition" of
>
> #define CACHE_LINE_SIZE 128
>
> in
>
> opal/include/opal/sys/cache.h
>
> although it's a bit "chicken and egg" because NetBSD's definition,
> in:
>
> /usr/include/sys/param.h
>
> obviously allows one to redefine it, vis:
>
> #ifndef CACHE_LINE_SIZE
> #define CACHE_LINE_SIZE 64
> #endif
>
> so that's probably not an issue but at least you know about it.

But here's a patch:

--- opal/include/opal/sys/cache.h.orig 2010-07-06 14:29:44.000000000 +1200
+++ opal/include/opal/sys/cache.h 2010-07-06 14:32:34.000000000 +1200
@@ -30,7 +30,9 @@
  *
  * For now hardwire this to a reasonable value, and automate later - RLG
  */
+#ifndef CACHE_LINE_SIZE
 #define CACHE_LINE_SIZE 128
+#endif

 #endif /* OPAL_SYS_CACHE_H */

-- 
Kevin M. Buckley                                  Room:  CO327
School of Engineering and                         Phone: +64 4 463 5971
 Computer Science
Victoria University of Wellington
New Zealand