I think adding support for sysv shared memory is a good thing. However, I have some strong objections over the implementation in the hg tree. Here are 2 of the major ones:
1) the sysv shared memory creation is __atomic__ based on the flags used. Therefore, all the RML messages exchange is totally useless.
2) the whole code is replicated in the 3 files (mmap, sysv and windows), even the common parts. However in the sysv case most of the comments have been modified to remove all capitals letter. I'm in favor of extracting all the common parts and moving them in a special file. What should be kept in the particular files should only be the really different parts (small part of the init and finalize).
On Jun 1, 2010, at 19:26 , Samuel K. Gutierrez wrote:
> Hi all,
> Configure option added: --enable-sysv (default: disabled).
> For sysv testing purposes, please enable.
> Samuel K. Gutierrez
> Los Alamos National Laboratory
> On Jun 1, 2010, at 11:11 AM, Samuel K. Gutierrez wrote:
>> bitbucket repository: http://bitbucket.org/samuelkgutierrez/ompi_sysv_sm
>> Samuel K. Gutierrez
>> Los Alamos National Laboratory
>> On Jun 1, 2010, at 11:08 AM, Samuel K. Gutierrez wrote:
>>> WHAT: New System V shared memory component.
>>> WHY: https://svn.open-mpi.org/trac/ompi/ticket/1320
>>> M ompi/mca/btl/sm/btl_sm.c
>>> M ompi/mca/btl/sm/btl_sm_component.c
>>> M ompi/mca/btl/sm/btl_sm.h
>>> M ompi/mca/mpool/sm/mpool_sm_component.c
>>> M ompi/mca/mpool/sm/mpool_sm.h
>>> M ompi/mca/mpool/sm/mpool_sm_module.c
>>> A ompi/mca/common/sm/configure.m4
>>> A ompi/mca/common/sm/common_sm_sysv.h
>>> A ompi/mca/common/sm/common_sm_windows.c
>>> A ompi/mca/common/sm/common_sm_windows.h
>>> A ompi/mca/common/sm/common_sm.c
>>> A ompi/mca/common/sm/common_sm_sysv.c
>>> A ompi/mca/common/sm/common_sm.h
>>> M ompi/mca/common/sm/common_sm_mmap.c
>>> M ompi/mca/common/sm/common_sm_mmap.h
>>> M ompi/mca/common/sm/Makefile.am
>>> M ompi/mca/common/sm/help-mpi-common-sm.txt
>>> M ompi/mca/coll/sm/coll_sm_module.c
>>> M ompi/mca/coll/sm/coll_sm.h
>>> WHEN: Upon acceptance.
>>> TIMEOUT: Tuesday, June 8, 2010 (after devel concall).
>>> MCA mpi: parameter "mpi_common_sm" (current value: <mmap>,
>>> data source: default value)
>>> Which shared memory support will be used. Valid
>>> values: sysv,mmap - or a comma delimited combination
>>> of them (order dependent). The first component that
>>> is successfully selected is used.
>>> Samuel K. Gutierrez
>>> Los Alamos National Laboratory
>>> devel mailing list
>> devel mailing list
> devel mailing list