Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: [OMPI devel] RFC: Change PML error handler signature
From: Rolf vandeVaart (rolf.vandevaart_at_[hidden])
Date: 2010-04-21 11:07:36


WHAT:
Add two arguments to the mca_pml_ob1_error_handler to make it more
useful for BTLs that may take advantage of that feature. Adding an
ompi_proc_t pointer and a char pointer. This is what the new signature
looks like.

void mca_pml_ob1_error_handler(
        struct mca_btl_base_module_t* btl,
        int32_t flags, ompi_proc_t *errproc, char *btlname) {

WHY:
There are times when the BTL wants to notify the PML not only that it
had an error, but also the endpoint the error occurred on. In addition,
we add a string so the BTL can put descriptive information like which
interface had the error.

WHERE: ompi/mca/pml/pml_ob1.c
                ompi/mca/btl/openib/btl_openib_component.c

MORE DETAILS:
I just want to expand the function signature by two variables. Not that
currently the only place the callback is used is in the openib BTL. And
when the callback is called, it just aborts the program. So this has no
effect whatsoever on the current library. I will also fix the signature
in the other PMLs to keep things consistent.

TIMEOUT: Monday, April 26, 2010 (as this is a minor change)