Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] typo in opal/event/evutil.h ?
From: Ralph Castain (rhc_at_[hidden])
Date: 2010-02-27 02:31:01


I checked the trunk and it is indeed wrong (the LONG had been fixed, but not this one). Why don't you go ahead and commit it?

On Feb 26, 2010, at 7:06 AM, Nadia Derbey wrote:

> On Fri, 2010-02-26 at 06:41 -0700, Ralph Castain wrote:
>> Hi Nadia
>>
>> I thought I saw a correction go by recently that fixed this in the
>> trunk? What revision are you at, and on which branch?
>
> Hi Ralph,
>
> 1) hg branch:
> default
> But I'm getting the warning in the v1.5 branch too.
>
> 2)
> changeset: 17631:177d287dee3c
> user: jsquyres
> date: Thu Feb 25 21:04:09 2010 +0000
> summary: This has bugged me for a long, long time: rename
> btl_openib_iwarp.*
> ->
>
> 3) configure options:
> --with-platform=../contrib/platform/optimized --enable-picky
>
> 4) Last update on this file is for me:
>
> changeset: 17413:32687831ca9e
> user: brbarret
> date: Thu Feb 04 05:38:30 2010 +0000
> summary: Update libevent to 1.4.13
>
> But maybe something got messed here in our repo, will check.
>
> Regards,
> Nadia
>
>>
>> On Fri, Feb 26, 2010 at 3:48 AM, Nadia Derbey <Nadia.Derbey_at_[hidden]>
>> wrote:
>> Hi,
>>
>> I'm getting this warning during the make if configured with
>> --enable-picky:
>> ../../../../opal/event/evutil.h:62:7: warning:
>> "_EVENT_SIZEOF_LONG_LONG"
>> is not defined
>> Looks like changeset #32687831ca9e has introduced a typo?
>> I'm wondering whether _EVENT_SIZEOF_LONG_LONG shouldn't be
>> changed to
>> SIZEOF_LONG_LONG?
>>
>>
>> --- a/opal/event/evutil.h Thu Feb 25 21:04:09 2010 +0000
>> +++ b/opal/event/evutil.h Fri Feb 26 10:29:31 2010 +0100
>> @@ -59,7 +59,7 @@ extern "C" {
>> #elif defined(WIN32)
>> #define ev_uint64_t unsigned __int64
>> #define ev_int64_t signed __int64
>> -#elif _EVENT_SIZEOF_LONG_LONG == 8
>> +#elif SIZEOF_LONG_LONG == 8
>> #define ev_uint64_t unsigned long long
>> #define ev_int64_t long long
>> #elif SIZEOF_LONG == 8
>>
>>
>> Regards,
>> Nadia
>> --
>> Nadia Derbey <Nadia.Derbey_at_[hidden]>
>>
>> _______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>> _______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> --
> Nadia Derbey <Nadia.Derbey_at_[hidden]>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel