Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [patch] Verifying the message queue DLL build
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-12-11 14:36:57


On Dec 8, 2009, at 6:55 AM, Ashley Pittman wrote:

> Attached is a patch to the OpenMPI sources which adds a simple test
> program, to be built and run as part of the build procedure that
> verifies the dll can be loaded without error.

Looks good.

> The test program itself is good, I'm less happy about the autoconf
> integration, it adds a check-local target in the debuggers makefile (the
> only one in the source tree) which fails if there is a problem with the
> DLL, this causes "make check" to fail however this isn't run by either
> "make" or "make install". As such it's a step forward but it would be
> better if the test was performed in the make stage, I haven't figured
> out how to do this however.

We actually run "make distcheck" to make the nightly snapshot tarballs and official test release tarballs (which runs "make check"). So we'll be covered.

Thanks!

-- 
Jeff Squyres
jsquyres_at_[hidden]