Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Invalid initializers in pml_base_request and bml_base_open
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-08-03 12:31:50


This looks icky.

George -- can you please fix?

On Aug 3, 2009, at 12:07 AM, Ralph Castain wrote:

> Hi folks
>
> The following lines were entered into two files by r21739:
>
> ompi/mca/pml/base/pml_base_request.c:
>
> ompi_free_list_t mca_pml_base_send_requests = {0};
> ompi_free_list_t mca_pml_base_recv_requests = {0};
>
> ompi/mca/bml/bml_base_open.c:
> opal_list_t mca_bml_base_components_available = {0};
>
> Unfortunately, these are not valid initializers as they do not
> properly init the object definition items in those objects. As a
> result, you get the following warnings:
>
> base/bml_base_open.c:32: warning: missing braces around initializer
> base/bml_base_open.c:32: warning: (near initialization for
> ‘mca_bml_base_components_available.super’)
> base/pml_base_request.c:27: warning: missing braces around initializer
> base/pml_base_request.c:27: warning: (near initialization for
> ‘mca_pml_base_send_requests.super’)
> base/pml_base_request.c:28: warning: missing braces around initializer
> base/pml_base_request.c:28: warning: (near initialization for
> ‘mca_pml_base_recv_requests.super’)
>
> We have been through this a few times - what you need to do is
> figure out a multi-stage bracketed init that correctly sets up the
> object. I played with it a little, but was unable to meet that
> requirement as it descends into multiple objects, eventually leading
> to a "initializer element is not computable at load time".
>
> George - svn says you committed these changes. Could you (perhaps
> with suggestions from someone out there?) please figure out a
> solution? Perhaps you need to find an alternative solution to the
> problem you were trying to solve.
>
> Thanks
> Ralph
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
jsquyres_at_[hidden]