Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |  

This web mail archive is frozen.

This page is part of a frozen web archive of this mailing list.

You can still navigate around this archive, but know that no new mails have been added to it since July of 2016.

Click here to be taken to the new web archives of this list; it includes all the mails that are in this frozen archive plus all new mails that have been sent to the list since it was migrated to the new archives.

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r21698
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-07-16 14:45:04


Even worse, I was trying to fix this by changing btl_sctp.c from

#include "opal/datatype/opal_convertor.h"

to

#include "ompi/datatype/ompi_convertor.h"

But then I get

#warning "This header file should only be included as a convenience.
Please use the opal_convert.h header, functions and macros"

And the top of that file has the following:

/*
  * XXX TODO To be deleted again.
  * Very small interface to have code, which depends on
ompi_convertor_prepare... interface
  * to work, still...
  *
  * However, still any header #include "opal/datatype/
opal_convertor.h" will need
  * to be renamed to #include "ompi/datatype/ompi_convertor.h"
  */

WTF?

I dislike that this header was put in as a workaround to not have to
update other code to match the new interface (i.e., they're all 1-
liner inline functions). This is significantly icky and should be
fixed. If you're going to update the interface, then update it.
Don't put a patchwork around making it look like you didn't update it.

On Jul 16, 2009, at 2:31 PM, Jeff Squyres (jsquyres) wrote:

> George --
>
> This does not compile.
>
> btl_sctp.c: In function `mca_btl_sctp_prepare_dst':
> btl_sctp.c:339: error: implicit declaration of function
> `ompi_datatype_type_lb'
> btl_sctp.c:339: error: `ompi_datatype_t' undeclared (first use in this
> function)
> btl_sctp.c:339: error: (Each undeclared identifier is reported only
> once
> btl_sctp.c:339: error: for each function it appears in.)
> btl_sctp.c:339: error: syntax error before ')' token
>
> Is there a missing header file?
>
>
>
> On Jul 16, 2009, at 2:25 PM, <bosilca_at_[hidden]> wrote:
>
> > Author: bosilca
> > Date: 2009-07-16 14:25:08 EDT (Thu, 16 Jul 2009)
> > New Revision: 21698
> > URL: https://svn.open-mpi.org/trac/ompi/changeset/21698
> >
> > Log:
> > No opal datatype functions in the BTL. The datatype attached to the
> > convertor is an ompi_datatype_t so calling the ompi level functions
> > is the way to go.
> >
> > Text files modified:
> > trunk/ompi/mca/btl/pcie/btl_pcie.c | 2 +-
> > trunk/ompi/mca/btl/sctp/btl_sctp.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Modified: trunk/ompi/mca/btl/pcie/btl_pcie.c
> > =
> > =
> > =
> > =
> > =
> > =
> > =
> > =
> >
> ======================================================================
> > --- trunk/ompi/mca/btl/pcie/btl_pcie.c (original)
> > +++ trunk/ompi/mca/btl/pcie/btl_pcie.c 2009-07-16 14:25:08 EDT
> > (Thu, 16 Jul 2009)
> > @@ -360,7 +360,7 @@
> > if(NULL == frag) {
> > return NULL;
> > }
> > - ompi_datatype_type_lb(convertor->pDesc, &lb);
> > + ompi_datatype_type_lb((ompi_datatype_t*)convertor->pDesc, &lb);
> > frag->segment.seg_addr.pval = convertor->pBaseBuf + lb +
> > convertor->bConverted;
> > if(NULL == registration) {
> >
> > Modified: trunk/ompi/mca/btl/sctp/btl_sctp.c
> > =
> > =
> > =
> > =
> > =
> > =
> > =
> > =
> >
> ======================================================================
> > --- trunk/ompi/mca/btl/sctp/btl_sctp.c (original)
> > +++ trunk/ompi/mca/btl/sctp/btl_sctp.c 2009-07-16 14:25:08 EDT
> > (Thu, 16 Jul 2009)
> > @@ -336,7 +336,7 @@
> > return NULL;
> > }
> >
> > - opal_datatype_type_lb(convertor->pDesc, &lb);
> > + ompi_datatype_type_lb((ompi_datatype_t*)convertor->pDesc, &lb);
> > frag->segments->seg_len = *size;
> > frag->segments->seg_addr.pval = convertor->pBaseBuf + lb +
> > convertor->bConverted;
> >
> > _______________________________________________
> > svn-full mailing list
> > svn-full_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
> >
>
>
> --
> Jeff Squyres
> Cisco Systems
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

-- 
Jeff Squyres
Cisco Systems