Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r21480
From: Ralph Castain (rhc_at_[hidden])
Date: 2009-06-19 23:59:11


I apologize - I had to revert this myself as it broke support for backend
launches on Torque and SLURM, which a number of us are actively using.
Please see the commit message for r21488 for a complete explanation.
Thanks
Ralph

On Fri, Jun 19, 2009 at 8:36 PM, Ralph Castain <rhc_at_[hidden]> wrote:

> I'm sorry, but this change is incorrect.
> If you look in orte/mca/ess/base/ess_base_std_orted.c, you will see that
> -all- orteds, regardless of how they are launched, open and select the PLM.
>
> This change causes rsh launched daemons to
> doubly-open/select the PLM, which is a very bad idea.
>
> Would you please revert this change?
>
> Thanks
> Ralph
>
>
> On Fri, Jun 19, 2009 at 12:50 PM, <coti_at_[hidden]> wrote:
>
>> Author: coti
>> Date: 2009-06-19 14:50:06 EDT (Fri, 19 Jun 2009)
>> New Revision: 21480
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/21480
>>
>> Log:
>> Initialize the PML if we are a non-HNP daemon.
>>
>> If we do not initialize the PML, non-HNP daemons will not be able to use
>> its functions. For example, RSH needs it when the tree_spawn mode is
>> enabled: daemons call orte_pml.remote_spawn() function to spawn their
>> children in the deployment tree.
>>
>>
>> Text files modified:
>> trunk/orte/mca/ess/env/ess_env_module.c | 14 ++++++++++++++
>> 1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> Modified: trunk/orte/mca/ess/env/ess_env_module.c
>>
>> ==============================================================================
>> --- trunk/orte/mca/ess/env/ess_env_module.c (original)
>> +++ trunk/orte/mca/ess/env/ess_env_module.c 2009-06-19 14:50:06 EDT
>> (Fri, 19 Jun 2009)
>> @@ -150,6 +150,20 @@
>> goto error;
>> }
>> opal_argv_free(hosts);
>> +
>> + /* in case we are asked to spawn remote daemons... */
>> + if (ORTE_SUCCESS != (ret = orte_plm_base_open())) {
>> + ORTE_ERROR_LOG(ret);
>> + error = "orte_plm_base_open";
>> + goto error;
>> + }
>> +
>> + if (ORTE_SUCCESS != (ret = orte_plm_base_select())) {
>> + ORTE_ERROR_LOG(ret);
>> + error = "orte_plm_base_select";
>> + goto error;
>> + }
>> +
>> return ORTE_SUCCESS;
>> }
>>
>> _______________________________________________
>> svn mailing list
>> svn_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>>
>
>