Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r21287
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-05-27 09:19:50


Note that this is a trunk change; no need or desire to bring it over
to the v1.3 branch. It's intended to be for v1.5.

FWIW, this type of flag probably should have been --enable to begin
with (not --with), because it's a boolean.

Will this cause significant headaches if the name changes in 1.5?

On May 27, 2009, at 6:47 AM, Ralph Castain wrote:

> Yes it is - so I'll have to change all the platform files, and alert
> people here as they will no longer be backwards compatible with the
> 1.3 series.
>
> This will cause some bookkeeping headaches, so I do hope the change
> was worth something and not just a "tomato" versus "tomahto" issue.
>
>
> On Tue, May 26, 2009 at 9:29 PM, Rainer Keller <keller_at_[hidden]>
> wrote:
> Dear all,
> please note, that with the separation of configure-flags into
> project-related
> sections, the one for openib-control-hdr-padding was moved.
>
> As Jeff noted, it is however most suitable in ompi_check_openib.m4.
> However, I put this as an AC_ARG_ENABLE, instead of an AC_ARG_WITH.
> Ralph, this is used by LANL, correct?
>
> With best regards,
> Rainer
>
>
> On Tuesday 26 May 2009 11:03:19 pm rusraink_at_[hidden] wrote:
> > #
> > + # Add padding to OpenIB header
> > + #
> > + AC_ARG_ENABLE([openib-control-hdr-padding],
> > + [AC_HELP_STRING([--enable-openib-control-hdr-padding],
> > + [Add padding bytes to the openib control header
> > (default:disabled)])])
>
> > -#
> > -# Add padding to OpenIB header
> > -#
> > -AC_MSG_CHECKING([whether to add padding to the openib control
> header])
> > -AC_ARG_WITH([openib-control-hdr-padding],
> > - [AC_HELP_STRING([--with-openib-control-hdr-padding],
> > - [Add padding bytes to the openib control
> header])])
>
>
> --
> ------------------------------------------------------------------------
> Rainer Keller, PhD Tel: +1 (865) 241-6293
> Oak Ridge National Lab Fax: +1 (865) 241-4811
> PO Box 2008 MS 6164 Email: keller_at_[hidden]
> Oak Ridge, TN 37831-2008 AIM/Skype: rusraink
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
Cisco Systems