Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r21234
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-05-14 10:03:56


On May 14, 2009, at 9:57 AM, Rainer Keller wrote:

> > This generated a bunch of warnings - the "z" length modifier is
> not a
> > generally supported option, which is why we do not use it.
> I see You compile with -pedantic?
>

Ya, configure adds that automatically if you --enable-picky.

> > btl_tcp_component.c: In function
> ‘mca_btl_tcp_component_create_listen’:
> > btl_tcp_component.c:682: warning: too many arguments for format
> This is the nice part of the attribute-fix: showing mistakes like
> this...
> Fixed...
>

Yep; it is good to expose all of these. Annoying to fix, but they
should be fixed. :-)

> > Could you please fix this? If you want to deal with the size_t 32/64
> > bit issues, there is another little macro thingy that we created for
> > just that purpose (someone else here undoubtedly remembers it).
> Well, does anyone now the "little macro thingy" ;-)
> I failed to find it...
>
> However, in other parts of the code base, we just use "%lu" and cast
> to
> unsigned long...
>

Unfortunately, I think that's the best we ever came up with:

     https://svn.open-mpi.org/trac/ompi/wiki/PrintfCodes

-- 
Jeff Squyres
Cisco Systems