Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r21234
From: Rainer Keller (keller_at_[hidden])
Date: 2009-05-14 09:57:32


Hey Ralph,
On Wednesday 13 May 2009 10:54:43 pm Ralph Castain wrote:
> This generated a bunch of warnings - the "z" length modifier is not a
> generally supported option, which is why we do not use it.
I see You compile with -pedantic?

> btl_tcp_frag.c: In function ‘mca_btl_tcp_frag_send’:
> btl_tcp_frag.c:115: warning: ISO C90 does not support the ‘z’ printf
> length modifier
> ...
see below.

> btl_tcp_component.c: In function ‘mca_btl_tcp_component_create_listen’:
> btl_tcp_component.c:682: warning: too many arguments for format
This is the nice part of the attribute-fix: showing mistakes like this...
Fixed...

> Could you please fix this? If you want to deal with the size_t 32/64
> bit issues, there is another little macro thingy that we created for
> just that purpose (someone else here undoubtedly remembers it).
Well, does anyone now the "little macro thingy" ;-)
I failed to find it...

However, in other parts of the code base, we just use "%lu" and cast to
unsigned long...
Thoughts?

Thanks,
Rainer

-- 
------------------------------------------------------------------------
Rainer Keller, PhD                  Tel: +1 (865) 241-6293
Oak Ridge National Lab          Fax: +1 (865) 241-4811
PO Box 2008 MS 6164           Email: keller_at_[hidden]
Oak Ridge, TN 37831-2008    AIM/Skype: rusraink