Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r21097
From: Ralph Castain (rhc_at_[hidden])
Date: 2009-04-28 21:59:29


Okay, I have found the correct fix. Please back this commit out and I
will submit the correct one.

Just a missing header file in orte_init.c

On Apr 28, 2009, at 7:55 PM, Ralph Castain wrote:

> Hmmm...even worse than I thought. We now have orte_name_wildcard and
> orte_name_invalid instantiated everywhere that orte_globals.h is
> used. This breaks everything in my systems as the values are no
> longer defined in a central place - so they are now undefined
> everywhere.
>
> I thought you had tested this before? Did this not show up??
>
>
> On Apr 28, 2009, at 7:46 PM, Ralph Castain wrote:
>
>> Ummm...no, that definitely is wrong, Rainer. Please back this out -
>> it doubly allocates memory for those variables. Like the comment
>> says, they are instantiated in orte_init.c.
>>
>>
>>
>> On Apr 28, 2009, at 7:44 PM, rusraink_at_[hidden] wrote:
>>
>>> Author: rusraink
>>> Date: 2009-04-28 21:44:43 EDT (Tue, 28 Apr 2009)
>>> New Revision: 21097
>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/21097
>>>
>>> Log:
>>> - So, this ain't right, but somewhere the orte-tools
>>> do not detect the orte_name_wildcard and orte_name_invalid.
>>>
>>>
>>> Text files modified:
>>> trunk/orte/runtime/orte_globals.h | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Modified: trunk/orte/runtime/orte_globals.h
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- trunk/orte/runtime/orte_globals.h (original)
>>> +++ trunk/orte/runtime/orte_globals.h 2009-04-28 21:44:43 EDT
>>> (Tue, 28 Apr 2009)
>>> @@ -53,9 +53,9 @@
>>>
>>> /* Shortcut for some commonly used names */
>>> #define ORTE_NAME_WILDCARD (&orte_name_wildcard)
>>> -ORTE_DECLSPEC extern orte_process_name_t orte_name_wildcard; /**
>>> instantiated in orte/runtime/orte_init.c */
>>> +ORTE_DECLSPEC orte_process_name_t orte_name_wildcard; /**
>>> instantiated in orte/runtime/orte_init.c */
>>> #define ORTE_NAME_INVALID (&orte_name_invalid)
>>> -ORTE_DECLSPEC extern orte_process_name_t orte_name_invalid; /**
>>> instantiated in orte/runtime/orte_init.c */
>>> +ORTE_DECLSPEC orte_process_name_t orte_name_invalid; /**
>>> instantiated in orte/runtime/orte_init.c */
>>>
>>> #define ORTE_PROC_MY_NAME (&orte_process_info.my_name)
>>>
>>> _______________________________________________
>>> svn mailing list
>>> svn_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>>
>