Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Minor patch for vtunify use of tolower()
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-02-27 18:33:36


It looks like the VT guys have applied this fix to the OMPI trunk and
filed for it to be moved to v1.3.

Thanks for the patch!

On Feb 27, 2009, at 4:11 AM, Number Cruncher wrote:

> I couldn't get Open MPI 1.3 to compile on RedHat 9 or CentOS3, due
> to vt_unify_stats.h using the tolower() function without including
> the relevant header.
>
> Attached is patch against 1.3 release to fix this minor bug.
> diff -r -U 5 openmpi-1.3.orig/ompi/contrib/vt/vt/tools/vtunify/
> vt_unify_stats.h openmpi-1.3/ompi/contrib/vt/vt/tools/vtunify/
> vt_unify_stats.h
> --- openmpi-1.3.orig/ompi/contrib/vt/vt/tools/vtunify/
> vt_unify_stats.h 2009-02-27 08:53:02.000000000 +0000
> +++ openmpi-1.3/ompi/contrib/vt/vt/tools/vtunify/vt_unify_stats.h
> 2009-02-27 09:01:55.000000000 +0000
> @@ -17,10 +17,11 @@
>
> #include <algorithm>
> #include <map>
> #include <string>
> #include <vector>
> +#include <cctype>
>
> // instance of class Statistics
> class Statistics;
> extern Statistics * theStatistics;
>
> @@ -73,13 +74,13 @@
> {
> std::string _a = funcname, _b = a.funcname;
> uint32_t i;
>
> for( i = 0; i < funcname.length(); i++ )
> - _a[i] = tolower( funcname[i] );
> + _a[i] = std::tolower( funcname[i] );
> for( i = 0; i < a.funcname.length(); i++ )
> - _b[i] = tolower( a.funcname[i] );
> + _b[i] = std::tolower( a.funcname[i] );
>
> return _a < _b;
> }
> else if( (flags & STAT_SORT_FLAG_FUNCNAME) &&
> (flags & STAT_SORT_FLAG_DIR_DOWN ) )
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
Cisco Systems