Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r20196
From: Aurélien Bouteiller (bouteill_at_[hidden])
Date: 2009-01-05 13:29:05


Tim,

To answer to your question in ticket #869: the only known missing
feature to the opal_stdint.h is that there is no portable way to
printf size_t. Their type is subject to so many changes depending on
the platform and compiler that it is impossible to be sure that
PRI_size_t is not gonna dump a lot of warnings. Aside from that, it
should be pretty solid.

Aurelien

Le 4 janv. 09 à 00:09, timattox_at_[hidden] a écrit :

> Author: timattox
> Date: 2009-01-04 00:09:18 EST (Sun, 04 Jan 2009)
> New Revision: 20196
> URL: https://svn.open-mpi.org/trac/ompi/changeset/20196
>
> Log:
> Refs #868, #869
>
> The fix for #868, r14358, introduced an (unneeded?) inconsitency...
> For Mac OS X systems, inttypes.h will always be included with
> opal_config.h,
> and NOT included for non-Mac OS X systems. For developers using Mac
> OS X,
> this masks the need to include inttypes.h or more properly
> opal_stdint.h.
>
> This changeset corrects one of these oopses. However, the
> underlying problem
> still exists. Moving the equivelent of r14358 into opal_stdint.h from
> opal_config_bottom.h might be the "right" solution, but AFAIK, we
> would then
> need to replace each direct inclusion of inttypes.h with
> opal_stdint.h to
> properly address tickets #868 and #869.
>
> Text files modified:
> trunk/opal/dss/dss_print.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Modified: trunk/opal/dss/dss_print.c
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/opal/dss/dss_print.c (original)
> +++ trunk/opal/dss/dss_print.c 2009-01-04 00:09:18 EST (Sun, 04 Jan
> 2009)
> @@ -18,6 +18,7 @@
>
> #include "opal_config.h"
>
> +#include "opal_stdint.h"
> #include <stdio.h>
>
> #include "opal/dss/dss_internal.h"
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn