Well, the commit itself doesn't modify the build process, as you just
added a new component. However, if people autogen, you component
doesn't correctly disable itself when not on Solaris. As a result, the
build fails on MAC OS X.
Here is the error I get at build time:
ranlib: file: .libs/libmca_memchecker.a(memchecker_base_wrappers.o)
has no symbols
memory_malloc_solaris_component.c:94: error: conflicting types for
/usr/include/sys/mman.h:212: error: previous declaration of munmap
memory_malloc_solaris_component.c:118:6: error: #error "Can not
determine how to call munmap"
And here is a snippet from the config.log:
configure:78271: checking for Solaris
configure:78988: result: no
configure:79050: checking if MCA component memory:malloc_solaris can
configure:79052: result: yes
On Aug 7, 2008, at 6:07 PM, Jeff Squyres wrote:
> Eh. Damage is done. Leave it in.
> We'll whip you later. ;-)
> On Aug 7, 2008, at 12:04 PM, Don Kerr wrote:
>> I just did a commit (-r19217) which I believe will require an
>> autogen. Since I was reminded that this is not good citizen
>> behavior for the middle of the day I will now start figuring out
>> how to back this out unless someone beats me to it.
>> -DON (with head hung low)
>> devel mailing list
> Jeff Squyres
> Cisco Systems
> devel mailing list
- application/pkcs7-signature attachment: smime.p7s