Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] openib component lock
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2008-08-06 07:05:33


On Aug 6, 2008, at 6:31 AM, Pavel Shamis (Pasha) wrote:

>> In working on https://svn.open-mpi.org/trac/ompi/ticket/1434, I see
>> fairly inconsistent use of the mca_openib_btl_component.ib_lock,
>> such as within btl_openib_proc.c.
>>
>> In fixing #1434, do I need to be mindful doing all the locking
>> properly, or is it already so broken that it doesn't really matter,
>> and all I need to do is ensure that I don't put in any bozo
>> deadlocks?
>>
> Hmm good question... I never tested thread build of openib btl, so I
> don't know if it really works. But we try to keep it thread safe.
> (All the thread stuff in openib btl require serious review..)

That's what I was thinking (it all requires a big review). Ok; I'll
just stay away from the boneheaded deadlocks.

-- 
Jeff Squyres
Cisco Systems